Skip to content

test(rmcp): retain settlement write authority - #757

Merged
ScriptedAlchemy merged 1 commit into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:codex/pr707-rmcp-settlement
Aug 30, 2026
Merged

test(rmcp): retain settlement write authority#757
ScriptedAlchemy merged 1 commit into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:codex/pr707-rmcp-settlement

Conversation

@BleedingDev

Copy link
Copy Markdown
Contributor

Summary

  • retain the registered global-database test runtime for the full broker fixture lifetime
  • preserve daemon settlement write authority until asynchronous delivery completes
  • leave production transport behavior unchanged

Why

The fixture kept only the database lease. The registered runtime that owns daemon write scope was dropped before asynchronous settlement, so delivery tests could strand attempts despite exercising valid production behavior.

Verification

  • successful response settlement passes
  • peer-disconnect dropped settlement passes
  • client-cancellation dropped settlement passes
  • aggregate focused suite: 14 passed
  • Rustfmt and diff checks pass

Supports #707.

@changeset-bot

changeset-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b046970

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T15:31:48.605058Z b046970 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 3d67835 into ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopened Aug 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants