fix(index): settle graph-off retained text wakes - #759
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79dba08e75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if graph_off_text_is_settled { | ||
| continue; |
There was a problem hiding this comment.
Preserve legitimate graph-off remount wakes
When an already-ready graph-off mount is remounted while an unhinted filesystem edit races the remount, this continue drops the only reconciliation wake. replace_existing_semantic_schedule deliberately emits a bare scheduler.wake.notify_one() so the next pass detects such an edit, but it sets neither PendingWakeV1 nor a scheduler hint; consequently this predicate misclassifies that wake as a stale text-slice permit and exact/lexical queries keep serving the retained generation until an unrelated later wake. Track the text-slice follow-up explicitly, or make meaningful control wakes establish pending work.
Useful? React with 👍 / 👎.
773a479
into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopened
Summary
Why
A graph-off worktree could enter an empty full-serving slot, then consume a stale coalesced wake as a second fake refresh. The exact unchanged-source journey consequently reported refreshing instead of fresh.
Verification
Supports #707.