Skip to content

fix(index): settle graph-off retained text wakes - #759

Merged
ScriptedAlchemy merged 1 commit into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:codex/pr707-graph-off-settle
Aug 30, 2026
Merged

fix(index): settle graph-off retained text wakes#759
ScriptedAlchemy merged 1 commit into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:codex/pr707-graph-off-settle

Conversation

@BleedingDev

Copy link
Copy Markdown
Contributor

Summary

  • bypass full retained-generation seating when native graph activation is disabled
  • let graph-off worktrees reconcile through the retained text owner
  • drain a stale no-work notification without suppressing real arrivals or raw overflow

Why

A graph-off worktree could enter an empty full-serving slot, then consume a stale coalesced wake as a second fake refresh. The exact unchanged-source journey consequently reported refreshing instead of fresh.

Verification

  • exact stale-witness regression passes 6 consecutive runs
  • all four graph-off scheduler tests pass
  • aggregate focused suite: 14 passed
  • Rustfmt and diff checks pass

Supports #707.

@changeset-bot

changeset-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 79dba08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T15:33:58.472946Z 79dba08 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79dba08e75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +2801 to +2802
if graph_off_text_is_settled {
continue;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve legitimate graph-off remount wakes

When an already-ready graph-off mount is remounted while an unhinted filesystem edit races the remount, this continue drops the only reconciliation wake. replace_existing_semantic_schedule deliberately emits a bare scheduler.wake.notify_one() so the next pass detects such an edit, but it sets neither PendingWakeV1 nor a scheduler hint; consequently this predicate misclassifies that wake as a stale text-slice permit and exact/lexical queries keep serving the retained generation until an unrelated later wake. Track the text-slice follow-up explicitly, or make meaningful control wakes establish pending work.

Useful? React with 👍 / 👎.

@ScriptedAlchemy
ScriptedAlchemy merged commit 773a479 into ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopened Aug 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants