Repository navigation
Return valid responses for pull diagnostics - #4263
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
textDocument/diagnosticcurrently returnsnullfor unsupported documents and when diagnostic computation fails, so clients cannot distinguish an empty report from a failed request.Implementation
Return an empty full report for unsupported document types and files outside the workspace. Return a JSON-RPC
RequestFailederror when diagnostic computation fails, while preserving the existing notifications and logging.Automated Tests
bundle exec bin/test test/server_test.rbpassed (68 runs, 395 assertions).bundle exec srb tc,bundle exec bin/rubocop lib/ruby_lsp/server.rb test/server_test.rb, andgit diff --checkpassed. Commands ran under Ruby 4.0.7; the repository pins Ruby 4.0.5.Manual Tests
Not run.