Repository navigation
Honor editor indexing exclusions in Rubydex - #4265
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4253. Ruby LSP's documented
excludedPatternsandexcludedGemsinitialization options are ignored with Rubydex, leaving unwanted workspace and gem files in the index.Implementation
Store the indexing options and apply exclusions after loading the Rubydex config. Resolve workspace patterns and excluded gem names to paths, while preserving
includedGemsoverrides. A server regression checks that excluded workspace and gem declarations are omitted while an included declaration remains indexed.Automated Tests
The focused regression passed (1 run, 5 assertions). RuboCop and Sorbet passed.
bundle exec rakefails on path-sensitive assertions involving macOS/tmpand/private/tmpresolution and the checkout path.Manual Tests
Not run.