[RaphaelFakhri]

What are you adding in this PR?

Fixes #1362

HardcodedRoutes used startsWith to match a hardcoded path against the routes table, so a path that only shares a prefix with a route was reported. /cartography was reported as /cart, /searching as /search, and /collections/all-shoes was reported as /collections/all with a suggestion to use routes.all_products_collection_url, which links to a different page.

The check now matches a route only when it is followed by the end of the value, /, ? or #. This applies to both href/action attributes and the link_to filter. /cart/change?line=1, /collections/{{ collection.handle }} and /cart#drawer are still reported.

What's next? Any followup issues?

None.

What did you learn?

The routes table is iterated in reverse so longer routes such as /collections/all win over /collections. With the boundary check, a longer route that does not match on a segment boundary now falls back to the shorter one.

Tophatting

Added a spec case with /cartography, /searching, /accounting, /carts, /collections/all-shoes and /cart#drawer. Without the source change the case fails with 6 offenses instead of 2.

npx vitest run packages/theme-check-common/src/checks/hardcoded-routes

• I added screenshots of the changes (before and after the changes if applicable)

Before you deploy

• I included a patch bump changeset

[RaphaelFakhri]

I have signed the CLA.

[RaphaelFakhri]

Rebased onto main. Since 97eb55d replaced the check tests with executable specs, the test case moved from hardcoded-routes/index.spec.ts to a should only match whole path segments case in specs/checks/hardcoded-routes.yml. The case fails without the change, and the HardcodedRoutes specs pass with it.