Repository navigation
feat(experiments): delete from list, launch new runs into an existing experiment - #88
Merged
Merged
Conversation
… experiment - Experiments list: per-row Delete (admin/auditor; admin for public), runs kept. - New Experiment: 'Add to experiment' picker to launch into an existing experiment instead of creating one; public targets need explicit consent. Works for single-run, multi-run review and repeating launches. - Experiment page: '+ New runs' button opens New Experiment preset via ?into=. - Same role rules as manual add_runs; run cap enforced under a row lock. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Replace the 'Add to experiment' select with a New/Existing toggle and a searchable list showing each experiment's run count, last update and public badge. Enter picks the first match; launching is blocked until an experiment is picked when 'Existing' is chosen.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExperimentDeleteViewand its confirm text; runs are kept and the user returns to the list.confirm_publicis enforced server-side, the same rule as manualadd_runs./experiments/new/?into=<id>preset.select_for_updatelock.Testing
infra/tests/test_experiment_attach.py(8 tests).confirm()was stubbed in the browser pane.