Repository navigation
Port partial atomic integer specs to libstdc++ - #127
Merged
Merged
Conversation
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | f5283df |
| fmdeps/BRiCk/ | main | 4d8da54 |
| fmdeps/auto/ | main | 14f9ff8 |
| fmdeps/auto-docs/ | main | f3ece99 |
| bluerock/NOVA/ | skylabs-proof | d802253 |
| bluerock/bhv/ | skylabs-main | bd2be4a |
| fmdeps/ci/ | main | 1092b1e |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| psi/data/ | main | b5b4e45 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-ext-lib/ | skylabs-master | a31ad69 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 8b34b7a |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 145998.9 | 145998.9 | -0.0 | total |
| -0.00% | 32793.6 | 32793.6 | -0.0 | ├ translation units |
| +0.00% | 113205.3 | 113205.3 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 145998.9 | 145998.9 | -0.0 | total |
| -0.00% | 32793.6 | 32793.6 | -0.0 | ├ translation units |
| +0.00% | 113205.3 | 113205.3 | +0.0 | └ proofs and tests |
pgiarrusso-sl
force-pushed
the
paolo/atomic-specs
branch
2 times, most recently
from
August 21, 2026 16:49
fbc8ea5 to
8a640b9
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | f5283df |
| fmdeps/BRiCk/ | main | 4d8da54 |
| fmdeps/auto/ | main | 14f9ff8 |
| fmdeps/auto-docs/ | main | f3ece99 |
| bluerock/NOVA/ | skylabs-proof | d802253 |
| bluerock/bhv/ | skylabs-main | bd2be4a |
| fmdeps/ci/ | main | 1092b1e |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| psi/data/ | main | b5b4e45 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-ext-lib/ | skylabs-master | a31ad69 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 856c831 |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 145998.9 | 145998.9 | +0.0 | total |
| +0.00% | 32793.6 | 32793.6 | +0.0 | ├ translation units |
| +0.00% | 113205.3 | 113205.3 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 145998.9 | 145998.9 | +0.0 | total |
| +0.00% | 32793.6 | 32793.6 | +0.0 | ├ translation units |
| +0.00% | 113205.3 | 113205.3 | +0.0 | └ proofs and tests |
pgiarrusso-sl
force-pushed
the
paolo/atomic-specs
branch
3 times, most recently
from
September 1, 2026 09:09
dbc8b33 to
7967331
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | fc2860d |
| fmdeps/BRiCk/ | main | f8dc05c |
| fmdeps/auto-docs/ | main | 6490c5f |
| bluerock/NOVA/ | skylabs-proof | eb2fd0d |
| bluerock/bhv/ | skylabs-main | e6646bb |
| fmdeps/ci/ | main | 6a09c2f |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | bef7df5 |
| fmdeps/rocq-agent-toolkit/ | main | 227bb83 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-lsp/ | skylabs-main | 64ef78a |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | c8da9fd |
| vendored/vsrocq/ | skylabs-main | ee79e7a |
Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 2 | |
| Warnings | 118 | 0 | 0 | 118 |
Code quality details
Rocq Files with Errors (2)
# Files with new errors
- fmdeps/auto/rocq-skylabs-cpp-stdlib/tests/atomic/test_cpp_proof.v
- fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/atomic/test_cpp_proof.v
❌ New Errors (2)
File "./fmdeps/auto/rocq-skylabs-cpp-stdlib/tests/atomic/test_cpp_proof.v", line 171, characters 6-16:
Error: The reference spec.do_op was not found in the current environment.
File "./fmdeps/brick-libcpp/rocq-brick-libstdcpp/proof/atomic/test_cpp_proof.v", line 77, characters 4-5:
Error: Syntax error: [lconstr] expected after '(' (in [elpi_cmd_arg]).
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.97% | 194408.4 | 196303.2 | +1894.8 | total |
| -0.41% | 814.9 | - | -814.9 | ├ disappeared files (1) |
| +1.37% | - | 2705.9 | +2705.9 | ├ newly appeared files (8) |
| +0.00% | 193593.5 | 193597.3 | +3.7 | └ common files |
| +0.00% | 52863.1 | 52863.4 | +0.3 | ├ translation units |
| +0.00% | 140730.4 | 140733.9 | +3.5 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +11.32% | 13.0 | 14.4 | +1.5 | fmdeps/auto/rocq-skylabs-cpp-stdlib/theories/atomic/pred.v |
| +16.61% | 12.1 | 14.1 | +2.0 | fmdeps/auto/rocq-skylabs-cpp-stdlib/theories/atomic/spec.v |
| +0.97% | 194408.4 | 196303.2 | +1894.8 | total |
| -0.41% | 814.9 | - | -814.9 | ├ disappeared files (1) |
| +1.37% | - | 2705.9 | +2705.9 | ├ newly appeared files (8) |
| +0.00% | 193593.5 | 193597.3 | +3.7 | └ common files |
| +0.00% | 52863.1 | 52863.4 | +0.3 | ├ translation units |
| +0.00% | 140730.4 | 140733.9 | +3.5 | └ proofs and tests |
Relocate imports and tests and regenerate the Dune rules, replacing the temporary build setup from the initial port.
pgiarrusso-sl
changed the title
pgiarrusso-sl
force-pushed
the
paolo/atomic-specs
branch
from
October 22, 2026 14:56
7967331 to
97b6ad3
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 781c507 |
| fmdeps/BRiCk/ | main | f08d690 |
| fmdeps/auto/ | main | 9008c20 |
| fmdeps/auto-docs/ | main | 5a40c23 |
| bluerock/NOVA/ | skylabs-proof | 0573bd1 |
| bluerock/bhv/ | skylabs-main | 3704d69 |
| fmdeps/brick-libgtest/ | main | aeeddad |
| fmdeps/ci/ | main | 2b73b2d |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | 7c6eef8 |
| fmdeps/rocq-agent-toolkit/ | main | 3369c0f |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 20adfbb |
| vendored/vsrocq/ | skylabs-main | 03db19e |
Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 77 | 0 | 78 |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.20% | 193951.2 | 194348.6 | +397.4 | total |
| +0.20% | - | 397.4 | +397.4 | ├ newly appeared files (6) |
| +0.00% | 193951.2 | 193951.2 | +0.0 | └ common files |
| +0.00% | 50229.4 | 50229.4 | +0.0 | ├ translation units |
| +0.00% | 143721.8 | 143721.8 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.20% | 193951.2 | 194348.6 | +397.4 | total |
| +0.20% | - | 397.4 | +397.4 | ├ newly appeared files (6) |
| +0.00% | 193951.2 | 193951.2 | +0.0 | └ common files |
| +0.00% | 50229.4 | 50229.4 | +0.0 | ├ translation units |
| +0.00% | 143721.8 | 143721.8 | +0.0 | └ proofs and tests |
pgiarrusso-sl
marked this pull request as ready for review
October 22, 2026 15:16
pgiarrusso-sl
force-pushed
the
paolo/atomic-specs
branch
from
October 24, 2026 10:02
97b6ad3 to
7d603cd
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 781c507 |
| fmdeps/BRiCk/ | main | f054b14 |
| fmdeps/auto/ | main | 693d659 |
| fmdeps/auto-docs/ | main | 918aa33 |
| bluerock/NOVA/ | skylabs-proof | 0573bd1 |
| bluerock/bhv/ | skylabs-main | 42f282b |
| fmdeps/brick-libgtest/ | main | 495b855 |
| fmdeps/ci/ | main | c1e1292 |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | 7c6eef8 |
| fmdeps/rocq-agent-toolkit/ | main | b307188 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 4cd041a |
| vendored/vsrocq/ | skylabs-main | 03db19e |
No Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 76 | 0 | 0 | 76 |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.20% | 195113.9 | 195511.1 | +397.2 | total |
| +0.20% | - | 397.2 | +397.2 | ├ newly appeared files (6) |
| -0.00% | 195113.9 | 195113.9 | -0.0 | └ common files |
| -0.00% | 49173.2 | 49173.2 | -0.0 | ├ translation units |
| +0.00% | 145940.7 | 145940.7 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.20% | 195113.9 | 195511.1 | +397.2 | total |
| +0.20% | - | 397.2 | +397.2 | ├ newly appeared files (6) |
| -0.00% | 195113.9 | 195113.9 | -0.0 | └ common files |
| -0.00% | 49173.2 | 49173.2 | -0.0 | ├ translation units |
| +0.00% | 145940.7 | 145940.7 | +0.0 | └ proofs and tests |
pgiarrusso-sl
commented
Oct 24, 2026
Comment on lines
42
to
+89
| @@ -84,5 +86,6 @@ main() { | |||
| TestStore(); | |||
| TestCAS(); | |||
| TestArith(); | |||
| TestFetchAdd(); | |||
Contributor
Author
There was a problem hiding this comment.
These test changes (and associated proof changes) should live in a separate commit, and be replicated in the other copy?
Reapply the namespace and base-class adaptations from the original port to the refreshed specs and proof tests.
Check assignment return and stored values, execute TestFetchAdd from main, and verify arithmetic and fetch-add cases separately.
pgiarrusso-sl
force-pushed
the
paolo/atomic-specs
branch
from
October 24, 2026 12:23
7d603cd to
51896e0
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 781c507 |
| fmdeps/BRiCk/ | main | 1fa93cf |
| fmdeps/auto/ | main | b110d1c |
| fmdeps/auto-docs/ | main | 918aa33 |
| bluerock/NOVA/ | skylabs-proof | 0573bd1 |
| bluerock/bhv/ | skylabs-main | 42f282b |
| fmdeps/brick-libgtest/ | main | 495b855 |
| fmdeps/ci/ | main | c1e1292 |
| vendored/elpi/ | skylabs-master | c0b9653 |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| vendored/rocq/ | skylabs-master | 7c6eef8 |
| fmdeps/rocq-agent-toolkit/ | main | b307188 |
| vendored/rocq-elpi/ | skylabs-master | 7dee592 |
| vendored/rocq-equations/ | skylabs-main | 9cf8471 |
| vendored/rocq-iris/ | skylabs-master | a7af9f7 |
| vendored/rocq-stdlib/ | skylabs-master | 00897b3 |
| vendored/rocq-stdpp/ | skylabs-master | 0c5e505 |
| fmdeps/skylabs-fm/ | main | 4cd041a |
| vendored/vsrocq/ | skylabs-main | 03db19e |
No Changes in Warnings or Errors
| Before | New | Fixed | After | |
|---|---|---|---|---|
| Errors | 0 | 0 | 0 | 0 |
| Warnings | 76 | 0 | 0 | 76 |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.20% | 194923.0 | 195304.5 | +381.6 | total |
| +0.20% | - | 397.2 | +397.2 | ├ newly appeared files (6) |
| -0.01% | 194923.0 | 194907.3 | -15.6 | └ common files |
| -0.00% | 49173.2 | 49173.2 | -0.0 | ├ translation units |
| -0.01% | 145749.8 | 145734.1 | -15.6 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.20% | 194923.0 | 195304.5 | +381.6 | total |
| +0.20% | - | 397.2 | +397.2 | ├ newly appeared files (6) |
| -0.01% | 194923.0 | 194907.3 | -15.6 | └ common files |
| -0.00% | 49173.2 | 49173.2 | -0.0 | ├ translation units |
| -0.01% | 145749.8 | 145734.1 | -15.6 | └ proofs and tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By Codex
Port the current partial atomic integer specifications from
fmdeps/auto/rocq-skylabs-cpp-stdlibto libstdc++, replacing the stale snapshot and unfinished experiments in the initial port.Details
The first commit is a byte-for-byte copy of all five atomic source/test files from SkyLabsAI/auto at `9008c20b7`. The remaining commits relocate imports and tests, regenerate Dune rules, and adapt libc++'s two base classes and `std::__1` namespace to libstdc++'s single `std::__atomic_base` base and `std` namespace. Changes already included in [SkyLabsAI/auto#391](https://github.com/SkyLabsAI/auto/pull/391) are omitted from the replay. Original contributor attribution is preserved.Coverage is limited to integral atomic specializations excluding
bool. Pointer, primary-template, and thread-ID atomics remain outside this port. The original PR head, including the thread-ID experiments, is preserved atbackup/atomic-specs-2026-10-22.The regression checks default/value construction, load/conversion, store/assignment, compare-exchange, exchange, arithmetic, and pre/post increment.
mainnow also runs the existing fetch-add test. The coverage changes are isolated in the final test commit and mirrored in SkyLabsAI/auto#637. That PR also fixes the libc++ assignment-spec receiver exposed by the new assignment test.Validation in the composed workspace build container:
make ide-prepare(with writable uv cache/data directories).dune buildofproof/atomic/spec.voandtest/atomic/test_cpp_proof.vo: passed, including all regression proofs..votargets, followed by a separate regression proof build: passed.proof/dune_incandtest/dune_incgenerated-rule checks: passed.clang++ -std=c++20 -stdlib=libstdc++: passed.The atomic regression proof omits ten confirmed no-op
normalize_ptrscalls and four redundantworkinvocations. Temporary progress checks verified all ten call sites and rejected a negative control that changes the goal; the cleaned proof then compiled without warnings. The standalone C++ compile emits the existing unusedmsgparameter warning.An additional package-wide
@fmdeps/brick-libcpp/installcheck was interrupted after several minutes in the unchangediostream/spec.vproof; the targeted atomic build and installation checks pass.