Repository navigation
rocq-brick-libstdcpp: declare rocq-skylabs-brick-cpp-prog dependency - #234
Closed
pgiarrusso-sl wants to merge 1 commit into
Closed
pgiarrusso-sl wants to merge 1 commit into
pgiarrusso-sl wants to merge 1 commit into
Conversation
The `skylabs.brick.libstdcpp` theory depends on
`skylabs.lang.cpp.parser.plugin` (package `rocq-skylabs-brick-cpp-prog`),
but the opam package did not declare that dependency, so the nightly
"Opam Install (paranoid = high)" job failed with
Theory "skylabs.lang.cpp.parser.plugin" has not been found.
which also broke rocq-brick-libgtest, which depends on this package.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #235: same commit on a branch name distinct from the auto one, so workspace CI tests the two PRs separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
brick-libcpppart of the failing nightly job Opam Install (paranoid = high), which installs every workspace package on its own.Companion to SkyLabsAI/BRiCk#438 (which only silences the rsync warnings) and SkyLabsAI/auto#640 fixing
rocq-skylabs-simpandrocq-skylabs-cpp-stdlib.skylabs.brick.libstdcpplistsskylabs.lang.cpp.parser.plugininproof/dune(the cpp2v-generated AST files requireskylabs.lang.cpp.parser.plugin.cpp2v, and the tests usecpp.prog), but the opam package did not depend onrocq-skylabs-brick-cpp-prog. Failure:This also broke
rocq-brick-libgtest, which depends on this package.Validation: ran the job's per-package install/uninstall loop over all 75 pinned workspace packages in a local container with this commit (plus the auto and BRiCk fixes); all pass. The opam file was regenerated by dune and matches.
🤖 Generated with Claude Code