Repository navigation
Bound the database pool size before converting it to int32 [skip deploy] #no-deploy - #5
Merged
SebastianLopezO merged 1 commit intoNov 1, 2026
Conversation
SebastianLopezO
force-pushed
the
security/codeql/incorrect-integer-conversion
branch
from
November 1, 2026 03:44
0b7bc1d to
bab66df
Compare
SebastianLopezO
deleted the
security/codeql/incorrect-integer-conversion
branch
November 1, 2026 03:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caso
go/incorrect-integer-conversionencmd/api/main.go:70.DATABASE_MAX_CONNSse leía constrconv.Atoi(entero del tamaño de la arquitectura) y se convertía aint32sin cota superior: un valor grande se desbordaba en silencio y el pool quedaba con un máximo negativo oarbitrario.
Cambio
postgres.Connectrecibeinty rechaza valores mayores queMaxPoolConns(1000) con un mensaje claro antes deconvertir.
pgxpool.Verificación
gofmt,go vetygo test ./...en verde.