Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
75b4daa
Stop attesting Maven pins a profile or user property overrides
mikolalysenko Nov 4, 2026
9765178
Address review: Maven discovery bypass checks match Maven precedence
mikolalysenko Nov 4, 2026
ec89bd9
Resolve Maven pin properties through profiles and nesting
mikolalysenko Nov 4, 2026
854c3f6
Address review: one Maven property resolver for VEX and vendoring
mikolalysenko Nov 6, 2026
e458517
Withhold Maven pins whose coordinates a profile redefines
mikolalysenko Nov 6, 2026
c77d5d5
Address review: weigh retargeted Maven coordinates with the shared ch…
mikolalysenko Nov 6, 2026
21fc630
Write no hosted Maven pin a profile's version bypasses
mikolalysenko Nov 6, 2026
402fccf
Write no hosted Maven pin an executable classifier copy bypasses
mikolalysenko Nov 6, 2026
64a07da
Address Bugbot: Maven config-only diagnostic and property-coordinate …
claude Nov 6, 2026
2af00b2
Fail closed on classifier copies managed only through a property
claude Nov 6, 2026
f3bfc05
Merge fix/maven-discovery-false-attestation into fix/maven-discovery-…
claude Nov 6, 2026
4ee6df8
Merge remote-tracking branch 'origin/fix/maven-discovery-property-ove…
claude Nov 6, 2026
139ea9d
Judge a Maven config override against the pin, not the spelling
claude Nov 6, 2026
6be1eb8
Merge remote-tracking branch 'origin/fix/maven-discovery-false-attest…
claude Nov 6, 2026
3389c34
Read Maven properties last-wins; profile coordinates and ids
claude Nov 6, 2026
c82973f
Merge remote-tracking branch 'origin/fix/maven-discovery-property-ove…
claude Nov 6, 2026
4487fa6
Weigh a retargeted typed classifier copy in hosted and discovery
claude Nov 6, 2026
8404531
Merge main into fix/maven-discovery-false-attestation
claude Nov 7, 2026
a6b3ab0
Merge remote-tracking branch 'origin/main' into pr2005
claude Nov 7, 2026
e98fa25
Merge origin/main into fix/maven-discovery-false-attestation
claude Nov 7, 2026
b6d0178
Merge remote-tracking branch 'origin/main' into fix/maven-discovery-f…
claude Nov 7, 2026
84967b1
Merge fix/maven-discovery-false-attestation into fix/maven-discovery-…
claude Nov 7, 2026
74fa073
Merge fix/maven-discovery-property-overrides into fix/maven-discovery…
claude Nov 7, 2026
935a66b
Weigh retargeted Maven classifier copies as discovery does
claude Nov 7, 2026
ab71a53
Merge origin/main into fix/maven-discovery-false-attestation
claude Nov 9, 2026
97dd4d0
Merge fix/maven-discovery-false-attestation into fix/maven-discovery-…
claude Nov 9, 2026
a8541ab
Merge fix/maven-discovery-property-overrides into fix/maven-discovery…
claude Nov 9, 2026
3d65680
Merge remote-tracking branch 'origin/main' into fix/maven-discovery-f…
mikolalysenko Nov 9, 2026
630fc37
Merge branch 'fix/maven-discovery-false-attestation' into fix/maven-d…
mikolalysenko Nov 9, 2026
46005e1
Merge branch 'fix/maven-discovery-property-overrides' into fix/maven-…
mikolalysenko Nov 9, 2026
ddf4808
Weigh profile versions of a parent-resolved pin property
mikolalysenko Nov 9, 2026
791ded0
Merge branch 'fix/maven-discovery-property-overrides' into fix/maven-…
mikolalysenko Nov 9, 2026
237307e
Keep coordinate docs on the no-profile reading after the #2020 merge
mikolalysenko Nov 9, 2026
37d9fd9
Read profile declarations' coordinates under their own profile
mikolalysenko Nov 9, 2026
dceb0ad
Merge remote-tracking branch 'origin/main' into fix/maven-discovery-f…
mikolalysenko Nov 9, 2026
157b6d4
Simplify the folded Maven VEX stack
mikolalysenko Nov 9, 2026
eda7b20
Address /code-review on the simplify commit
mikolalysenko Nov 9, 2026
823619f
Read an empty <type> as jar when a profile moves coordinates
mikolalysenko Nov 9, 2026
de7254b
Merge remote-tracking branch 'origin/main' into fix/maven-discovery-f…
mikolalysenko Nov 9, 2026
05906f4
Merge remote-tracking branch 'origin/main' into fix/maven-discovery-f…
mikolalysenko Nov 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/socket-patch-cli/CLI_CONTRACT.md

Large diffs are not rendered by default.

25 changes: 23 additions & 2 deletions crates/socket-patch-cli/src/commands/vex_sources.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,15 @@ const NOTE_NPM_SHRINKWRAP_ONLY: &str = "vex_npm_shrinkwrap_only";
/// Omission tag and note: a hosted Maven pin sits in a reactor root, where a
/// module's own `<version>` may override it (`vex::Unattested`).
const NOTE_MAVEN_REACTOR_ROOT: &str = "vex_maven_reactor_root";
/// Omission tag and note: a hosted Maven pin's GA also has an executable
/// classifier copy at another version, which the pin does not reach
/// Omission tag and note for [`UnattestedKind::MavenClassifierUnpatched`]
/// (`vex::Unattested`).
const NOTE_MAVEN_CLASSIFIER_UNPATCHED: &str = "vex_maven_classifier_unpatched";
/// Omission tag and note for [`UnattestedKind::MavenProfileUnpatched`]
/// (`vex::Unattested`).
const NOTE_MAVEN_PROFILE_UNPATCHED: &str = "vex_maven_profile_unpatched";
/// Omission tag and note for [`UnattestedKind::MavenConfigOverride`]
/// (`vex::Unattested`).
const NOTE_MAVEN_CONFIG_OVERRIDE: &str = "vex_maven_config_override";
/// Omission tag and note: a hosted Cargo pin beside another declaration of
/// the crate that names no Socket registry, which cargo resolves as a
/// separate, unpatched package (`vex::Unattested`).
Expand Down Expand Up @@ -311,6 +316,22 @@ fn unattested_note(kind: UnattestedKind) -> (&'static str, &'static str) {
"not attested while that classifier copy resolves an unpatched version; the \
wiring itself is intact, so re-running `scan` does not change this",
),
UnattestedKind::MavenProfileUnpatched => (
NOTE_MAVEN_PROFILE_UNPATCHED,
"not attested while a profile declares it at, or its <properties> move it to, \
another version, or its <properties> redefine a groupId / artifactId property so \
the pin names another package or another declaration names this one; the wiring \
itself is intact, so re-running `scan` does not change this (drop that profile \
<version> or property or set it to the pin; `scan --mode vendored` rewrites a \
literal profile <version>, but neither mode wires a pin a profile's <properties> \
can move, and hosted `scan` writes no pin a profile bypasses)",
),
UnattestedKind::MavenConfigOverride => (
NOTE_MAVEN_CONFIG_OVERRIDE,
"not attested while .mvn/maven.config redefines the property it is spelled \
through; the wiring itself is intact, so re-running `scan` does not change this \
(drop that -D from .mvn/maven.config, or write the pinned version literally)",
),
UnattestedKind::CargoUnpinnedDeclaration => (
NOTE_CARGO_UNPINNED_DECLARATION,
"not attested while that declaration stands",
Expand Down
1,126 changes: 992 additions & 134 deletions crates/socket-patch-core/src/formats/maven/mod.rs

Large diffs are not rendered by default.

Loading
Loading