Skip to content

Retry setup-ruby once so release 504s can't fail Ruby legs #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikola Lysenko (mikolalysenko) merged 2 commits into from
Nov 9, 2026
+33 −2
Merged

Retry setup-ruby once so release 504s can't fail Ruby legs #2041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c541f
Retry setup-ruby once after a release 504
claude Nov 9, 2026
fe2db1c
Drop the pause between setup-ruby attempts
claude Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1609,9 +1609,18 @@ jobs:
if: matrix.pipenv != '' || matrix.pip != ''
run: uv python install 3.8 3.11 3.12

- name: Setup Ruby
- name: Setup Ruby (attempt 1)
# setup-ruby downloads the prebuilt Ruby from a github.com release
# and gives up after ~1 min of retries. On 2026-11-09 (nightly run
# 42568829044) a ~4 min release-CDN 504 outage failed two gem legs
# and hosted-e2e here. Try once more, with setup-ruby's own ~1 min
# of retries again; a second failure is not a blip. (Attempt 2
# must be the very next step: test_merge_queue_fail_fast.py.)
id: setup-ruby
if: matrix.suite == 'e2e_gem' || matrix.bundler != ''
uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
timeout-minutes: 4
continue-on-error: true
with:
# setup-ruby does NOT support `3.2.x` wildcard pinning the
# way setup-python does — it errors with "Unknown version
Expand All @@ -1628,6 +1637,15 @@ jobs:
bundler: 'none'
bundler-cache: false

- name: Setup Ruby (attempt 2)
if: (matrix.suite == 'e2e_gem' || matrix.bundler != '') && steps.setup-ruby.outcome != 'success'
uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
timeout-minutes: 4
with:
ruby-version: ${{ matrix.ruby || '3.2.10' }}
bundler: 'none'
bundler-cache: false

# The legs pin their bundler (`bundler:`) so a capstone never rides
# whatever bundler the runner's Ruby ships; e2e_gem keeps the 2.5
# floor. A two-part version gets the `~> X.Y.0` requirement setup-ruby's
Expand Down Expand Up @@ -2874,16 +2892,29 @@ jobs:
if: steps.gate.outputs.run == 'true'
run: scripts/pip-install-retry.sh uv && uv --version

- name: Setup Ruby
- name: Setup Ruby (attempt 1)
# Capped and retried once, as in the e2e job.
id: setup-ruby
if: steps.gate.outputs.run == 'true'
uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
timeout-minutes: 4
continue-on-error: true
with:
ruby-version: '3.2.10'
# Bundler comes from the next step, which retries rubygems.org
# blips; setup-ruby's own install is a single bare `gem install`.
bundler: 'none'
bundler-cache: false

- name: Setup Ruby (attempt 2)
if: (steps.gate.outputs.run == 'true') && steps.setup-ruby.outcome != 'success'
uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
timeout-minutes: 4
with:
ruby-version: '3.2.10'
bundler: 'none'
bundler-cache: false

- name: Install Bundler
if: steps.gate.outputs.run == 'true'
# The gem hosted rewrite pins into the Gemfile.lock CHECKSUMS
Expand Down
Loading