Repository navigation
Sync/main from staging - #213
Merged
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix(dev): use authn compatibility login flow
…@3.1.3-5) (latest: rdflib@2.3.9)
…e-pane into solidosDependencies
Solidos dependencies
reverse to inherit secrets
…@5.0.0-0) (latest: rdflib@2.4.0)
Staging version
…6.0.0 solid-ui@5.0.1)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Bundle compatibility, modal accessibility, cancellation, rendering, and CI checkout issues remain unresolved.
Review effort: Balanced
Findings: 3
Open (8)
Pin CI checkout to the updater commit SHA · New Return a placeholder node from showError() · New Preserve $rdf browser global for the rdflib external · New Add accessible modal focus management to the overlay · New Restore prior aria-hidden values after dialog closes · New Re-enable new issue button when top-level form is cancelled · New Disable concurrent webpack output cleaning · New Correct documented Node version to match .nvmrc · New
What changed in this PR
Synchronizes staging changes that modernize packaging, styling, error handling, and CI for the issue pane.
Changes:
- Produces normal and minified UMD bundles under
lib. - Adds component CSS, accessible dialogs, and improved error reporting.
- Updates dependencies, development setup, and publishing workflows.
| File | Description |
|---|---|
webpack.module.rules.mjs |
Centralizes loader rules. |
webpack.dev.config.mjs |
Reuses shared module rules. |
webpack.config.mjs |
Reworks production bundles and assets. |
src/newTracker.js |
Improves errors and styling. |
src/newTracker.css |
Styles tracker creation button. |
src/newIssue.js |
Adds cancellation and save-error UI. |
src/newIssue.css |
Styles new-issue forms. |
src/localUtils.js |
Adds reusable alert dialogs. |
src/localUtils.css |
Styles modal dialogs. |
src/issuePane.js |
Integrates styling and error sections. |
src/issuePane.css |
Styles pane controls and errors. |
src/issue.js |
Refactors issue UI and overlays. |
src/issue.css |
Styles issue cards and dialogs. |
src/errors.js |
Adds error-section utilities. |
src/errors.css |
Preserves hidden error sections. |
src/debug.js |
Centralizes console logging. |
src/csvButton.js |
Improves CSV copy feedback. |
src/csvButton.css |
Adds CSV stylesheet placeholder. |
src/board.js |
Moves board styling to CSS. |
src/board.css |
Defines board presentation. |
README.md |
Documents setup and AI usage. |
package.json |
Introduces v4 packaging and dependencies. |
eslint.config.mjs |
Ignores generated library files. |
dev/index.js |
Updates development login handling. |
dev/dev-global.css |
Adds local development theme. |
declarations.d.ts |
Declares Turtle imports. |
.gitignore |
Ignores generated lib. |
.github/workflows/ci.yml |
Updates dependency and publishing CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # fork PRs keep the default commit, as the updater deliberately does not commit there. | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ github.event_name == 'pull_request' && (github.event.pull_request.head.repo.fork && github.sha || github.head_ref) || github.ref_name }} |
Comment on lines
211
to
+213
| if (!stateArray) { | ||
| return complain(`Configuration error: state ${states} does not have substates`) | ||
| error(`Configuration error: state ${states} does not have a disjointUnionOf`) | ||
| return showError(`Configuration error: state ${states} does not have substates`) |
| 'isomorphic-fetch': 'fetch', | ||
| 'text-encoding': 'TextEncoder', | ||
| '@trust/webcrypto': 'crypto', | ||
| rdflib: 'rdflib', |
Comment on lines
+114
to
+118
| const button = issuePanel.appendChild( | ||
| widgets.button(context.dom, icons.iconBase + 'noun_1180156.svg', 'close', hideOverlay)) | ||
| button.classList.add('trackerOverlayCloseButton') | ||
| delete button.style.backgroundColor // do not want white | ||
| overlay.classList.add('trackerOverlayVisible') |
Comment on lines
+60
to
+66
| function hideSiblings (hide, dom) { | ||
| const siblings = Array.from(dom.body.children).filter(c => c !== modalOverlay) | ||
| siblings.forEach(el => { | ||
| if (hide) el.setAttribute('aria-hidden', 'true') | ||
| else el.removeAttribute('aria-hidden') | ||
| }) | ||
| } |
| if (form.parentNode) { | ||
| form.parentNode.removeChild(form) | ||
| } | ||
| onCancel() |
| module: { | ||
| rules: [ | ||
| globalObject: 'this', | ||
| clean: true, |
|
|
||
| # Development Setup | ||
|
|
||
| This project uses Node `20.19.2` (see `.nvmrc`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.