Fix bugs and improve styling/mobile for release - #737
Open
SharonStrats wants to merge 13 commits into
Open
Conversation
Prompt: storage has the same problem as profile please investigate the profile and social fix and include storage Co-authored-by: Claude Optus 5 <claudeoptus5@openai.com>
…@3.1.3-17 pane-registry@3.1.2-2 activitystreams-pane@1.0.3-4 chat-pane@3.0.4-3 contacts-pane@3.2.1-6 folder-pane@3.1.1-3 issue-pane@3.0.3-1 meeting-pane@3.0.3-1 profile-pane@3.2.3-4 source-pane@3.1.1-7) (latest: rdflib@2.4.0)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on polishing the release UI/UX (especially on mobile) and tightening pane restoration behavior by moving inline styles into CSS, improving header/layout responsiveness, and updating how pane selection is restored from URL/history state.
Changes:
- Extracts outline table cell styling from inline JS into
manager.css, adding mobile overrides. - Updates main page pane selection/restoration logic (URL vs history) and improves refresh behavior for panes that use their own subject URI.
- Refactors the file explorer header controls/actions for improved mobile behavior (ellipsis menu, conditional actions) and updates related styling.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/outline/manager.js | Removes inline TD styling; relies on CSS classes for layout/styling. |
| src/outline/manager.css | Defines .obj / .iconTD styles and a small-screen media query for outline table cells. |
| src/mainPage/index.ts | Adjusts initial pane choice (URL/history) and refresh subject restoration via paneUri. |
| src/components/resource-actions-menu/ResourceActionsMenu.ts | Reworks action menu to support mobile-specific Edit/Share items and container-aware Share. |
| src/components/resource-actions-menu/ResourceActionsMenu.styles.css | Adds icon sizing for the ellipsis trigger icon. |
| src/components/file-explorer-header/helper.ts | Adds helpers to detect containers and count container items. |
| src/components/file-explorer-header/FileExplorerProvider.ts | Adds share icon import for consistent icon availability. |
| src/components/file-explorer-header/FileExplorerHeaderSummary.ts | Adds container-specific header rendering (item count vs modified date). |
| src/components/file-explorer-header/FileExplorerHeaderSummary.styles.css | Updates typography/layout and adds mobile responsive styling. |
| src/components/file-explorer-header/FileExplorerHeaderControls.ts | Adds mobile detection and moves actions into the ellipsis menu on small screens/containers. |
| src/components/file-explorer-header/FileExplorerHeaderControls.styles.css | Normalizes icon sizing and hides action buttons at smaller widths. |
| src/components/file-explorer-header/FileExplorerHeader.styles.css | Adjusts header padding and adds a bottom border. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TallTed
reviewed
Aug 14, 2026
…@3.1.3-17 pane-registry@3.1.2-2 activitystreams-pane@1.0.3-4 chat-pane@3.0.4-3 contacts-pane@3.2.1-6 folder-pane@3.1.1-3 issue-pane@3.0.3-1 meeting-pane@3.0.3-1 profile-pane@3.2.3-4 source-pane@3.1.1-7) (latest: rdflib@2.4.0)
…id-panes into fix/bugs-for-release
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Contributor
Author
|
Since we are not releasing we don't need to do this now, it can be done as we go. |
…@3.1.3-17 pane-registry@3.1.2-2 activitystreams-pane@1.0.3-4 chat-pane@3.0.4-3 contacts-pane@3.2.1-6 folder-pane@3.1.1-3 issue-pane@3.0.3-1 meeting-pane@3.0.3-1 profile-pane@3.2.3-4 source-pane@3.1.1-7) (latest: rdflib@2.4.0)
timea-solid
requested changes
Aug 19, 2026
| accessor canEdit: boolean = false | ||
|
|
||
| @state() | ||
| accessor isMobile = typeof window !== 'undefined' && typeof window.matchMedia === 'function' |
Member
There was a problem hiding this comment.
this watchMedia is interesting but I believe this is where maybe we should work with the pane-registry environment. For this release, this is fine for now.
| import '~icons/lucide/folder' | ||
| import styles from './FileExplorerHeaderSummary.styles.css' | ||
| import { type FileExplorerResourceMetadata } from './helper' | ||
| import { getContainerItemCount, isContainerSubject, type FileExplorerResourceMetadata } from './helper' |
Member
There was a problem hiding this comment.
in solid-panes we have, brand new, a podUtils unders utils... O believe some functions and logic is now duplicate and yes, it should be in solid-logic actually. We can consolidate later ioni worst case.
| modified: string | undefined | ||
| } | ||
|
|
||
| export function isContainerSubject (store: LiveStore | undefined, subjectUri: string | undefined): boolean { |
Member
There was a problem hiding this comment.
we could at least move it to podUtils for now
| const parentFolderUri = this.getParentFolderUri(resourceUri) | ||
| ;(outliner as any).GotoSubject(sourceContext.context.session.store.sym(parentFolderUri), true, undefined, true, undefined) | ||
| } */ | ||
| accessor handleSharingClick: (() => void) | undefined = undefined |
Member
There was a problem hiding this comment.
lets rename sharing to access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement mobile styling and export file explorer provider and header from index.ts.
Note that most are temporary changes for releasing as the structure will change, so it's just an attempt to match the design as close as possible but taking into consideration the current layout.