Skip to content

Adding curation panel during merge focus #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 3 commits into from
Sep 7, 2026
Merged

Adding curation panel during merge focus #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c44a96
fixing the test_mainwindow and added merge_focus testing
QinyaoWeng Aug 27, 2026
3fbbe05
change the preset view by adding the curation panel when running merg…
QinyaoWeng Aug 27, 2026
e24aaf8
feat: add layout cli arg to test scripts
alejoe91 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spikeinterface_gui/layout_presets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ def get_layout_description(preset_name, layout=None):

merge_focus_layout = dict(
zone1=['merge', 'unitlist'],
zone2=['waveform'],
zone2=['curation'],
zone3=['spikeamplitude'],
zone4=['ndscatter'],
zone5=['probe'],
zone6=[],
zone7=['spikerate'],
zone7=['waveform'],
zone8=['correlogram'],
)

Expand Down
7 changes: 4 additions & 3 deletions spikeinterface_gui/tests/test_mainwindow_panel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def teardown_module():
clean_all(test_folder)


def test_mainwindow(start_app=False, verbose=True, curation=False, only_some_extensions=False, events=False, port=0):
def test_mainwindow(start_app=False, verbose=True, curation=False, only_some_extensions=False, events=False, port=0, layout="default"):


analyzer = load_sorting_analyzer(test_folder / "sorting_analyzer")
Expand Down Expand Up @@ -78,7 +78,7 @@ def test_mainwindow(start_app=False, verbose=True, curation=False, only_some_ext
curation=curation, curation_dict=curation_dict,
displayed_unit_properties=None,
extra_unit_properties=extra_unit_properties,
layout_preset='default',
layout_preset=layout,
# address="10.69.168.40",
port=port,
events=events_dict
Expand Down Expand Up @@ -112,6 +112,7 @@ def test_launcher(verbose=True):
parser = ArgumentParser()
parser.add_argument('--dataset', default="small", help='Path to the dataset folder')
parser.add_argument('--events', action="store_true", help='Simulate and add events')
parser.add_argument('--layout', default="default", help='Layout of the GUI, default is "default"')

if __name__ == '__main__':
args = parser.parse_args()
Expand All @@ -123,7 +124,7 @@ def test_launcher(verbose=True):
if not test_folder.is_dir():
setup_module()

win = test_mainwindow(start_app=True, verbose=True, curation=True, events=args.events, port=0)
win = test_mainwindow(start_app=True, verbose=True, curation=True, events=args.events, port=0, layout=args.layout)

# test_launcher(verbose=True)

Expand Down
7 changes: 4 additions & 3 deletions spikeinterface_gui/tests/test_mainwindow_qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def teardown_module():
clean_all(test_folder)


def test_mainwindow(start_app=False, verbose=True, curation=False, only_some_extensions=False, events=False):
def test_mainwindow(start_app=False, verbose=True, curation=False, only_some_extensions=False, events=False, layout="default"):


analyzer = load_sorting_analyzer(test_folder / "sorting_analyzer")
Expand Down Expand Up @@ -108,7 +108,7 @@ def test_mainwindow(start_app=False, verbose=True, curation=False, only_some_ext
curation=curation, curation_dict=curation_dict,
displayed_unit_properties=None,
extra_unit_properties=extra_unit_properties,
layout_preset='default',
layout_preset=layout,
events=events_dict
# user_settings={"mainsettings": {"color_mode": "color_by_visibility", "max_visible_units": 5}}
)
Expand Down Expand Up @@ -144,6 +144,7 @@ def test_launcher(verbose=True):
parser = ArgumentParser()
parser.add_argument('--dataset', default="small", help='Path to the dataset folder')
parser.add_argument('--events', action="store_true", help='Simulate and add events')
parser.add_argument('--layout', default="default", help='Enable layout preset')

if __name__ == '__main__':
args = parser.parse_args()
Expand All @@ -155,7 +156,7 @@ def test_launcher(verbose=True):
if not test_folder.is_dir():
setup_module()

win = test_mainwindow(start_app=True, verbose=True, curation=True, events=args.events)
win = test_mainwindow(start_app=True, verbose=True, curation=True, events=args.events, layout=args.layout)
# win = test_mainwindow(start_app=True, verbose=True, curation=False)

# test_launcher(verbose=True)
2 changes: 1 addition & 1 deletion spikeinterface_gui/tests/testingtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ def make_analyzer_folder(test_folder, case="small", unit_dtype="str"):
sorting_analyzer.compute("correlograms", window_ms=50., bin_ms=1.)
sorting_analyzer.compute("template_similarity", method="l1")
sorting_analyzer.compute("principal_components", n_components=3, mode='by_channel_global', whiten=True, **job_kwargs)
sorting_analyzer.compute(["spike_amplitudes", "spike_locations"], **job_kwargs)
sorting_analyzer.compute("quality_metrics", metric_names=["snr", "firing_rate"])
sorting_analyzer.compute("template_metrics")
sorting_analyzer.compute(["spike_amplitudes", "spike_locations"], **job_kwargs)


def make_curation_dict(analyzer):
Expand Down
Loading