Extend preprocessing pipeline by defining a BasePipeline - #4755
Open
alejoe91 wants to merge 8 commits into
Open
Conversation
…extend-preprocessing-pipeline
alejoe91
commented
Sep 4, 2026
| source_class_or_dict_of_sources_classes.__doc__ = source_class.__doc__ | ||
| source_class_or_dict_of_sources_classes.__name__ = name | ||
| # propagate the _precomputable_kwarg_names attribute from the source class to the wrapper function | ||
| source_class_or_dict_of_sources_classes._precomputable_kwarg_names = source_class._precomputable_kwarg_names |
Member
Author
There was a problem hiding this comment.
@chrishalcrow doing this allows us to get rid of the pp_names_to_classes
alejoe91
commented
Sep 4, 2026
| precomputable_kwarg_names = preprocessor_class._precomputable_kwarg_names | ||
| dont_apply_kwargs += precomputable_kwarg_names | ||
| preprocessor_function = self.function_names_to_functions[preprocessor_name] | ||
| if hasattr(preprocessor_function, "_precomputable_kwarg_names"): |
Member
Author
There was a problem hiding this comment.
Here we added _precomputed_kwarg_names to the function, but we still protect against not having the attrs
See https://github.com/SpikeInterface/spikeinterface/pull/4755/changes#r3932091422
alejoe91
marked this pull request as ready for review
September 4, 2026 08:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasePipelineto allow inherited classes to define their own dictionary of steps to check against