Only use nonempty main channel indices when making an analyzer from templates - #4763
Open
chrishalcrow wants to merge 1 commit into
Open
Conversation
chrishalcrow
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a
main_channel_indicesbug. When you usecreate_sorting_analyzer_with_existing_templates(done inside e.g. SK2 and Lupin) the sorting might have fewer units than there are templates. This is because some templates end up having no spikes clustered to them (especially happens if you use a template library generated from a different recording, for fun ;) ). So we usually throw away these units.This PR ensures that when we throw away these units, we update the
main_channel_indicesaccordingly.