Repository navigation
circus-omp fixes and improvements - #4950
Open
grahamfindlay wants to merge 1 commit into
Open
grahamfindlay wants to merge 1 commit into
grahamfindlay wants to merge 1 commit into
Conversation
With the default vicinity, circus-omp could select a template it had already selected at the same time. This either cut the matching pass short, losing later spikes, or overwrote the spike's amplitude, sometimes with very large values. Each new selection now re-fits nearby selected templates to what is left of the signal (LocOMP, Mailhé et al., 2009), and a template is never selected twice at the same time. This recovers more spikes, gets rid of the very large amplitudes, and is slightly faster.
yger
approved these changes
Nov 18, 2026
yger
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, and I've done some local tests, results seems to be very slightly improved, with no speedup impact. Good catch for the bug! Maybe @samuelgarcia want to also have a look before merging, but it won't be before next week at the latest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default
vicinity=2, circus-omp sometimes picks the same template at the same time twice. The amplitude fit can't tell two these identical atoms apart, so one of two things goes wrong:This PR replaces the windowed amplitude update used when
vicinity > 0with LocOMP (Mailhé et al., ICASSP 2009), which never picks the same template at the same time twice and, after each pick, re-fits the amplitudes of nearby spikes on the same channels to whatever signal is still unexplained. Nothing changes withvicinity=0. Amplitude estimates are improved (which has knock-on effects improving e.g. template re-estimation), recall is improved ~6 pts without loss of precision, with the biggest gains when spikes are dense, and matching is ~10% faster than it was.