Repository navigation
Fix spike holes with the default NT in Kilosort 2.5 and 3 - #4952
grahamfindlay wants to merge 1 commit into
Conversation
Kilosort 2.5.2 and 3.0.2 expect this value (or another multiple of 1024, minus ntbuff). The old default left a hole of missed spikes at the end of every batch. Kilosort installs from before the fix keep the old value (because it is less harmful than the new one if you don't have the fix) and get a warning.
|
What should happen for an older compiled installation? In This is from reading the wrapper and the new tests; I have not run either sorter. |
|
I didn't even know it could be compiled... Looking into it, does that ever happen outside of SpikeInterface's own Docker images? The latest images have the fix, so they're fine. I'd be hesitant to add a warning, because most users would just get a warning with nothing for them to act on. I guess if someone had an older unpatched image pinned by hand they could get holes with the new defaults, but I don't see how to tell which Kilosort versions those older images use. I'm not even sure which Kilosort the |
Defaults Kilosort 2.5 / 3 batch size to
64 * 1024 - ntbuffto avoid spike holes. See #2562 .Since the new value
64 * 1024 - ntbuffis actually worse than the old value of64 * 1024 + ntbuffif you don't have a patched version of Kilosort, I added a check for the installed Kilosort version (bit of a hack, but I'm not sure how better to do it), and pick the best value ofNTaccordingly. And warn if the user has an unpatched version.