Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions doc/releases/0.105.5.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
.. _release0.105.5:

SpikeInterface 0.105.5 release notes
------------------------------------

November 18th 2026

Minor release with bug fixes

sorters:

* Dartsort: fix passing pre-computed ``si_motion`` (#4953)


Contributors:

* @alejoe91
3 changes: 2 additions & 1 deletion doc/whatisnew.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Release notes
.. toctree::
:maxdepth: 1

releases/0.105.5.rst
releases/0.105.4.rst
releases/0.105.3.rst
releases/0.105.2.rst
Expand Down Expand Up @@ -67,7 +68,7 @@ Release notes
releases/0.9.1.rst


Versions 0.105.1/4
Versions 0.105.1/5
==================

* Minor releases with bug fixes and performance improvements
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "spikeinterface"
version = "0.105.4"
version = "0.105.5"
authors = [
{ name="Alessio Buccino", email="alessiop.buccino@gmail.com" },
{ name="Samuel Garcia", email="sam.garcia.die@gmail.com" },
Expand Down
11 changes: 8 additions & 3 deletions src/spikeinterface/sorters/external/dartsort.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np

from ..basesorter import BaseSorter
from ...core import load
from ...core import load, Motion


class DartsortSorter(BaseSorter):
Expand Down Expand Up @@ -40,6 +40,9 @@ def _dynamic_params(cls):
for k, props in schema["$defs"]["DARTsortUserConfig"]["properties"].items():
default_params_descriptions[k] = props["title"]

default_params.update({"si_motion": None})
default_params_descriptions.update({"si_motion": "SpikeInterface motion object (optional)"})

return default_params, default_params_descriptions

@classmethod
Expand Down Expand Up @@ -73,7 +76,9 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
recording = cls.load_recording_from_folder(sorter_output_folder.parent, with_warnings=False)

# Dartsort can be given the motion object optionaly
motion = params.pop("motion", None)
si_motion = params.pop("si_motion", None)
if si_motion is not None:
si_motion = Motion.from_dict(si_motion)

# dartsort config are set using dataclass we need to map this
cfg = DARTsortUserConfig(**params)
Expand All @@ -82,7 +87,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
recording,
sorter_output_folder,
cfg,
motion=motion,
si_motion=si_motion,
)
# the DARTsortSorting is not the spikeinterface sorting
dartsort_sorting = ret["sorting"]
Expand Down