Repository navigation
ReviewSLA: make anyone who requests changes or comments an assignee - #54
Draft
willson556 wants to merge 1 commit into
Draft
willson556 wants to merge 1 commit into
willson556 wants to merge 1 commit into
Conversation
A reviewer who requests changes or leaves review comments is someone the author now waits on, but only the two picked assignees had clocks, reminders and a place on the dashboard. In remind mode ReviewSLA now assigns them to that PR (shadow mode logs it), and records them in the Review SLA comment's hidden state so out-of-office reassignment leaves their reviews alone and AssignReviewers doesn't carry them up the stack. Their review is their first response; a re-request after a push starts their re-review clock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer who requests changes, or leaves comments, is someone the author now waits on. Only the two picked assignees had SLA clocks, reminders and a place on the dashboard, so a re-request to anyone else went untracked.
Rule (in
remindmode;shadowonly logs who it would add): on a ready PR, anyone except the author or a bot who has requested changes, or left a comment review with a body or inline comments, since the PR was last marked ready is made an assignee of that PR. This uses the same "counts as a response" test as the SLA clock.Recorded in the Review SLA comment. The hidden marker now also holds
added, the people assigned this way, for as long as they stay assigned. The comment is created on such a PR even when nobody owes a review yet. The record is used in two places:Not changed: they count toward their open assigned PRs when AssignReviewers picks by load. We decided to start that way and see.
Rollout note: the first
remindrun will add everyone who qualifies on PRs that are open right now, all at once. Each of them gets a normal GitHub assignment notification.Tests:
owed.test.js)node --testpasses all 118 tests.Both READMEs describe the new behavior.
🤖 Generated with Claude Code