Repository navigation
Keep bank and tavern rows off the ledger until they count something - #272
Conversation
The journal unlocks after 15 hours of fishing, usually before the bank and the tavern, yet the ledger always listed interest, drinking and gambling at zero - naming places the player hadn't been shown. Those rows now follow the same skip-the-zero rule as Money Lost While Drunk and the career blocks. Closes #271 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The account's starting cent earns a rounded-up dollar every night, so moneyMadeFromInterest is non-zero long before the bank unlocks and the skip-the-zero rule alone brought the row back after the first sleep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Self-review rubric (head after commit 2, CI test + docker green):
FAIL found and fixed in commit 2: the first version gated the interest row on non-zero only. Judgment call left visible: a player who has the bank unlocked but has earned $0 interest also has no interest row. That matches the skip-the-zero rule used everywhere else on the ledger. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
Summary
Home._statsLinesnow shows the Money Made From Interest, Times Gotten Drunk and Money Lost Gambling rows only when they are non-zero. This is the rule Money Lost While Drunk and_careerBlockalready follow. The ledger (progression.JOURNAL, 15 hours of fishing) usually opens before the bank and the tavern are revealed, so the zero rows named places the player hadn't been shown yet.Closes #271
Skipped issues
Shop.moneynot persisted): left for a human merge decision. The fix touches the protectedschemas/*.jsonand*JsonReaderWriter.pypaths.Test plan
test_displayStats_omits_bank_and_tavern_rows_until_they_count_somethingfails with thehome.pyfix stashed and passes with it restoredtest_displayStats_bank_and_tavern_rows_keep_their_order_once_earnedpins the order and format of the rowsTimes Gotten Drunk: 0, a zero row that is now hidden. It was updated to a non-zero count (7).black --checkis clean on the changed Python filesNo protected paths are touched (no schema, save-manager, reader/writer or workflow changes).
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson