Repository navigation
Say "1 hour", "1 fish is", "1 hand" and "1 day" at the docks - #275
Merged
Merged
Conversation
The catch report, the export run's leftover note, the voyage provisioning header and the foundering report all printed the plural for a count of one - "over 1 hours" turned up on about one cast in ten. Closes #274 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (one pass, anchored on green CI for head
Notes:
One self-review pass is complete, with no findings to address in the diff. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four strings in
src/location/docks.pyused the plural form when the count was exactly 1. Each one now uses the same inline conditional as #261:The second count in the provisioning header (
plan["legs"]) is left as it was, because every voyage plan has 4, 7 or 11 legs.Closes #274
Test plan
tests/location/test_docks.py, one per string at a count of 1. With thesrc/change stashed, all four failed; with it restored, all four passed.test_fish_always_lands_at_least_one_fish("over 3 hours!"),test_provisioning_says_when_each_option_runs_out("3 hands aboard for 11 days.") andtest_voyageReport_reads_as_a_disaster_when_she_founders("3 days out of 11."). The existing "40 fish are still in the hold" assertion is unchanged.black --checkpasses on both changed files.Docs
Deferred issues
schemas/*.jsonand*JsonReaderWriter.py, which are do-not-auto-merge paths, so it is left for a human merge decision.progression.BANK, start at 0), and choosing between them is a design decision for the maintainer.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson