Repository navigation
Report and count unnamed hands lost on a captained voyage - #278
Merged
dmccoystephenson merged 1 commit intoNov 13, 2026
Merged
Conversation
finishVoyage took lost unnamed legacy hands off the boat and the headcount but left them out of the summary, so the homecoming report said "all hands accounted for" and the ledger's Crew Lost at Sea row missed them. Carry the count as summary["handsLost"], add it to crewLostToPiracy, and read it back beside any names in the report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 43368602435:
Notes found outside the diff, with no change made:
Every rubric item passes after an adversarial read. The one judgment call is the wording "N unnamed hand(s)", which matches how the docks crew menus already refer to legacy hands ("Put an unnamed hand aboard", "%d unnamed hand(s)", This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/count-unnamed-hands-lost-on-voyage
branch
November 13, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adventures.finishVoyagenow records unnamed legacy hands who didn't come back assummary["handsLost"], and adds them tostats.crewLostToPiracy(the ledger's "Crew Lost at Sea" row) alongside named villagers.Docks._voyageReportreads that count back next to any names ("Owen Brackish and 2 unnamed hands did not come back"). A voyage that lost only unnamed hands is therefore no longer reported as "all hands accounted for"..get("handsLost", 0)keeps hand-built summaries working.Closes #277
Skipped open issues
*JsonReaderWriter/schemas), so it needs a human merge decision.Test plan
tests/business/test_adventures.pytests: the summary and the stats count unnamed hands lost, and a voyage with everyone home counts 0.tests/location/test_docks.pytests: singular "1 unnamed hand", named and unnamed losses together in the plural, and a realfinishVoyagesummary fed into the report.black --checkpasses on all four changed files.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson