Repository navigation
Quote the crew's wages as a cost at the bank - #283
Merged
Merged
Conversation
Margaret called totalWagesPaid money the crew "brought in" and the player's "profits". It is the payroll the player has paid out, so both lines now describe it that way and aim the savings advice at what is left after payday. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (PR #283, head CI green:
Judgement call flagged:
Out-of-diff observations (not filed; the impact is cosmetic):
Local suite: 1132 passed under dummy SDL drivers. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stats.totalWagesPaidas money the crew "brought in", and (on a Fishing Fleet) as "those profits". The stat is the payroll the player has paid out (src/business/boats.py:477), and the journal and overnight report already show it as a cost.Bank._businessDialoguenow describe the figure as wages paid to the crew, and the savings advice is aimed at what is left after payday. The$<amount>and "retire a wealthy soul" phrases that existing tests check are kept.Closes #282
Skipped issues
schemas/*.json,*JsonReaderWriter.py), so it needs a human merge decision.Test plan
tests/location/test_bank.py::test_npc_business_dialogue_quotes_wages_as_a_cost_not_income[1|3]added. It fails with the fix stashed and passes with it applied.black --checkis clean on both changed files.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson