Skip to content

Quote the crew's wages as a cost at the bank - #283

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/bank-wages-are-a-cost
Nov 16, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/bank-wages-are-a-cost

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • Margaret's "What do you think of my fishing business?" answer quoted stats.totalWagesPaid as money the crew "brought in", and (on a Fishing Fleet) as "those profits". The stat is the payroll the player has paid out (src/business/boats.py:477), and the journal and overnight report already show it as a cost.
  • Both branches of Bank._businessDialogue now describe the figure as wages paid to the crew, and the savings advice is aimed at what is left after payday. The $<amount> and "retire a wealthy soul" phrases that existing tests check are kept.
  • The gap was found by checking each stat's displays for the direction of money flow (paid out vs. earned).

Closes #282

Skipped issues

Test plan

  • tests/location/test_bank.py::test_npc_business_dialogue_quotes_wages_as_a_cost_not_income[1|3] added. It fails with the fix stashed and passes with it applied.
  • Full suite run locally under dummy SDL drivers: 1132 passed.
  • black --check is clean on both changed files.
  • CI is green on the PR head.

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

Margaret called totalWagesPaid money the crew "brought in" and the
player's "profits". It is the payroll the player has paid out, so
both lines now describe it that way and aim the savings advice at
what is left after payday.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (PR #283, head CI green: test and docker both pass):

  • Scope: PASS. Only src/location/bank.py (the two dialogue branches named in Margaret calls the crew's wage bill money they "brought in" and "profits" #282, plus a one-line comment) and its test file change.
  • Tests-new: PASS. No new public method was added. The changed behaviour is covered by the new parametrized test for tiers 1 and 3.
  • Tests-fix: PASS. With src/location/bank.py stashed, both parametrized cases FAIL ("brought in" and "profits" are present). With the stash popped, all 44 bank tests pass.
  • Sibling structure: PASS. The new test follows the # prepare / # call / # check layout and the createBank() factory used by its neighbours.
  • Sibling renames: PASS (not applicable). No identifiers were renamed.
  • Docs: PASS. README lines 111, 116 and 162 already describe wages as paid out. PLANNING.md, the schemas and version.txt are unaffected.
  • Issue resolution: PASS. Both lines quoted in Margaret calls the crew's wage bill money they "brought in" and "profits" #282 were rewritten. The $<amount> and "retire a wealthy soul" assertions in the existing tests still hold.
  • CI: PASS. Run 43803314156 is green on the head commit.
  • Schema-sync: PASS (not applicable). No persisted field was touched.
  • Money-format: PASS. totalWagesPaid only ever accumulates workers * WORKER_DAILY_WAGE (an int), so $%d is unchanged and correct.
  • Deterministic-tests: PASS. No randomness is involved.
  • Headless-pygame: PASS (not applicable).
  • camelCase: PASS. No new identifiers were added.

Judgement call flagged:

  • tests/location/test_bank.py:215 (the new positive assertion) uses an or across the two branch phrasings, so it is looser than a per-branch assertion. The negative assertions ("brought in", "profits") carry the regression guard, so this was left as is.

Out-of-diff observations (not filed; the impact is cosmetic):

  • src/location/bank.py:112: "A boat with no crew is just a rowboat and a dream!" is said for an uncrewed boat of any tier.
  • src/location/bank.py:107: a player who has sold their last boat but still has hired crew on the payroll is told "A boat's a fine goal to save toward!", with no mention of the wages still running.

Local suite: 1132 passed under dummy SDL drivers. black --check is clean on both files.

This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit 84ca73f into main Nov 16, 2026
2 checks passed
@dmccoystephenson
dmccoystephenson deleted the feature/bank-wages-are-a-cost branch November 16, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Margaret calls the crew's wage bill money they "brought in" and "profits"

1 participant