Repository navigation
fix: the story page no longer says Teo is still running the generator - #50
Merged
Merged
Conversation
…#49) The THE OTHER COUNT paragraph is fixed text and can be read after the storm night or after Marit takes the generator key, so it now says what Teo did from the night the plane left, as the TEOS_NIGHTS fact already does. The stale-text test gains a "has been running" entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head f6a9185):
Out-of-diff observation:
This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
facts.TEOS_NIGHTSparagraph insrc/overwinter/premise.py("THE OTHER COUNT") is fixed text that can be read after the storm night or after Marit has taken the generator key. It is rewritten so it holds on any day: "Teo ran the generator all night from the night the plane left, because he cannot sleep in the dark, and the storm margin of fuel went on it." This matches the past tense already given to theTEOS_NIGHTSfact in fix: nobody talks as if Aksel were still across the bay after he walks in #48.tests/test_facts.py::test_nothing_with_one_fixed_text_says_the_storm_is_still_to_comegains a"has been running"entry, so the stale wording cannot return to any fact, premise paragraph or table-talk line.Marit's own question "Teo's been running the generator all night, every night." in
people.pywas checked and left as it is: it is gated byundecidedAboutTeo, which hides it after the storm night and once the key is taken.Test plan
python3 -m pytest: 185 passedpremise.pychange stashed,tests/test_facts.pyfails on the new entry; with it restored, the file passes (6 tests)Deferred issues
src/overwinter/state.py, which is on the do-not-auto-merge list. It should go in its own PR for human review.Closes #49
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson