Skip to content

fix: the story page no longer says Teo is still running the generator - #50

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/teo-premise-past-tense
Nov 11, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/teo-premise-past-tense

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • The facts.TEOS_NIGHTS paragraph in src/overwinter/premise.py ("THE OTHER COUNT") is fixed text that can be read after the storm night or after Marit has taken the generator key. It is rewritten so it holds on any day: "Teo ran the generator all night from the night the plane left, because he cannot sleep in the dark, and the storm margin of fuel went on it." This matches the past tense already given to the TEOS_NIGHTS fact in fix: nobody talks as if Aksel were still across the bay after he walks in #48.
  • tests/test_facts.py::test_nothing_with_one_fixed_text_says_the_storm_is_still_to_come gains a "has been running" entry, so the stale wording cannot return to any fact, premise paragraph or table-talk line.

Marit's own question "Teo's been running the generator all night, every night." in people.py was checked and left as it is: it is gated by undecidedAboutTeo, which hides it after the storm night and once the key is taken.

Test plan

  • python3 -m pytest: 185 passed
  • With the premise.py change stashed, tests/test_facts.py fails on the new entry; with it restored, the file passes (6 tests)
  • CI green on the PR head

Deferred issues

Closes #49

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

…#49)

The THE OTHER COUNT paragraph is fixed text and can be read after the
storm night or after Marit takes the generator key, so it now says what
Teo did from the night the plane left, as the TEOS_NIGHTS fact already
does. The stale-text test gains a "has been running" entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (head f6a9185):

  • Scope: PASS — two files: the one premise paragraph named in The story page still says Teo has been running the generator all night, after the storm and the key #49, and the stale-text test it suggested.
  • Tests-new: PASS — no new public functions. The existing fixed-text test gains a "has been running" entry.
  • Tests-fix: PASS — with src/overwinter/premise.py stashed, tests/test_facts.py::test_nothing_with_one_fixed_text_says_the_storm_is_still_to_come FAILS (1 failed, 5 passed). With it restored, the file passes (6 passed).
  • Sibling structure / renames: PASS — no new files and no renames.
  • Docs: PASS — docs/STORY.md line 26 describes the design in the story's present tense and does not quote the premise paragraph, so it was left alone. facts.TEOS_NIGHTS already uses the past tense (fix: nobody talks as if Aksel were still across the bay after he walks in #48).
  • Issue resolution: PASS — the paragraph The story page still says Teo has been running the generator all night, after the storm and the key #49 names now holds on any day.
  • CI: PASS — docker, test (3.8) and test (3.12) are green on the PR head.
  • Knowledge-gated / Calendar in one place / One RNG: PASS — no conditions, calendar code or randomness were touched.
  • Save format: PASS — state.py and schemas/save.json are untouched.
  • Solvable: PASS — tests/test_game.py and tests/test_endings.py are unmodified, and all 185 tests pass locally.
  • Flags and endings / Vendored client: PASS — not touched.

Out-of-diff observation: src/overwinter/people.py:223, Marit's question "Teo's been running the generator all night, every night.", is also present tense. It is gated by undecidedAboutTeo (no key taken, storm night not passed), so it only appears while the wording is still true. It was left as it is.

black --check could not be run in this sandbox. CI does not enforce it, and the edited lines follow the file's existing wrapping.

This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit 6ee7858 into main Nov 11, 2026
3 checks passed
@dmccoystephenson
dmccoystephenson deleted the feature/teo-premise-past-tense branch November 11, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The story page still says Teo has been running the generator all night, after the storm and the key

1 participant