Skip to content

fix: the 1958 depot is laid for twenty-four days, so half of it is twelve rations - #52

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/depot-laid-for-twenty-four-days
Nov 15, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/depot-laid-for-twenty-four-days

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • The 1958 log entry (scenes/office.py) and the THE_DEPOT fact (facts.py) now say the depot was laid "for twenty-four days at one man", not twelve. This matches the two dozen tins found in Strip.depot: half are left behind and twelve rations come home.
  • The comment above DEPOT_FOOD in state.py was updated to match. DEPOT_FOOD stays at 12, so the count, the balance and the save format are unchanged.
  • A regression test was added: tests/test_strip.py::test_the_depot_as_laid_is_twice_what_comes_back_once_half_is_left checks that the laid figure in the log and the fact is twice DEPOT_FOOD, and that the walk still reports two dozen tins, half swollen, and DEPOT_FOOD rations.

Closes #40

Test plan

  • python3 -m pytest: 190 passed
  • The new test was confirmed to fail with the three source edits stashed (the log text lacks "twenty-four days at one man") and to pass with them restored
  • python3 -m black --check passes on the four changed files
  • docs/STORY.md and README.md were checked. Neither quotes the laid figure. Both say "three days at four once the swollen tins are left behind", which still holds.

Deferred

Merge note

src/overwinter/state.py is on this repo's do-not-auto-merge list (save format). The only change there is a comment, and no field, constant or schema changed. The PR is still left open for human approval under that rule.

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

…elve rations

The log entry and THE_DEPOT fact said the depot was laid "for twelve
days at one man", but the walk to the cairn finds two dozen tins, leaves
the swollen half behind and still brings home DEPOT_FOOD = 12 rations.
The laid figure now reads twenty-four days in the log, the fact and the
state.py comment; DEPOT_FOOD and the count are unchanged.
tests/test_strip.py pins the laid figure to twice DEPOT_FOOD.

Closes #40

drafted by Claude on behalf of Daniel Stephenson

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (head of feature/depot-laid-for-twenty-four-days, CI green: test (3.8), test (3.12), docker):

  • Scope: PASS. Four files changed. Three are the one-line text and comment edits The depot is laid for twelve days, half is left behind, and it still yields twelve rations #40 names (scenes/office.py, facts.py, state.py), and the fourth is the regression test. No formatting churn (python3 -m black --check is clean on all four).
  • Tests-new: PASS. No new public functions were added.
  • Tests-fix: PASS. This was checked empirically. With the three source edits stashed, test_the_depot_as_laid_is_twice_what_comes_back_once_half_is_left failed ('twenty-four days at one man' in <log text> was False). With them restored, it passed.
  • Sibling structure: PASS. The test follows the everything([...]) / game.ui.saw(...) pattern of its neighbours in tests/test_strip.py.
  • Sibling renames: PASS. Nothing was renamed.
  • Docs: PASS. docs/STORY.md:30 and README.md:44 give the depot as "three days at four once the swollen tins are left behind". That is still true, and neither quotes the laid figure. version.txt is already 0.3.1-SNAPSHOT.
  • Issue resolution: PASS. All three places The depot is laid for twelve days, half is left behind, and it still yields twelve rations #40 lists now say twenty-four days, and DEPOT_FOOD stays at 12 as the issue proposes.
  • CI: PASS. All three checks are green on the PR head.
  • Knowledge-gated / Calendar in one place: PASS. No conditions or calendar events were touched.
  • Save format: PASS. state.py changed only in a comment. No field, constant value or schema changed, so old saves load unchanged.
  • One RNG: PASS. grep -rn 'random\.' src/overwinter matches only state.py (and its stale .pyc).
  • Solvable: PASS. tests/test_game.py and tests/test_endings.py pass unmodified (190 passed).
  • Flags and endings: PASS. No flags or endings were changed.
  • Vendored client untouched: PASS. trace_client.py is not in the diff.

Merge gate: src/overwinter/state.py is on the do-not-auto-merge list. The change there is comment-only and carries no save-format risk, but the rule is path-based, so this PR is left open for human approval.

This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit b572c52 into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The depot is laid for twelve days, half is left behind, and it still yields twelve rations

1 participant