Repository navigation
fix: the 1958 depot is laid for twenty-four days, so half of it is twelve rations - #52
Merged
Merged
Conversation
…elve rations The log entry and THE_DEPOT fact said the depot was laid "for twelve days at one man", but the walk to the cairn finds two dozen tins, leaves the swollen half behind and still brings home DEPOT_FOOD = 12 rations. The laid figure now reads twenty-four days in the log, the fact and the state.py comment; DEPOT_FOOD and the count are unchanged. tests/test_strip.py pins the laid figure to twice DEPOT_FOOD. Closes #40 drafted by Claude on behalf of Daniel Stephenson Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head of
Merge gate: This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scenes/office.py) and theTHE_DEPOTfact (facts.py) now say the depot was laid "for twenty-four days at one man", not twelve. This matches the two dozen tins found inStrip.depot: half are left behind and twelve rations come home.DEPOT_FOODinstate.pywas updated to match.DEPOT_FOODstays at 12, so the count, the balance and the save format are unchanged.tests/test_strip.py::test_the_depot_as_laid_is_twice_what_comes_back_once_half_is_leftchecks that the laid figure in the log and the fact is twiceDEPOT_FOOD, and that the walk still reports two dozen tins, half swollen, andDEPOT_FOODrations.Closes #40
Test plan
python3 -m pytest: 190 passedpython3 -m black --checkpasses on the four changed filesdocs/STORY.mdandREADME.mdwere checked. Neither quotes the laid figure. Both say "three days at four once the swollen tins are left behind", which still holds.Deferred
Merge note
src/overwinter/state.pyis on this repo's do-not-auto-merge list (save format). The only change there is a comment, and no field, constant or schema changed. The PR is still left open for human approval under that rule.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson