Repository navigation
test: pin Aksel at the galley table and a night that falls outside the bunkroom - #53
Merged
dmccoystephenson merged 1 commit intoNov 15, 2026
Conversation
…e bunkroom No playthrough talked to Aksel in the galley, and none let an evening action outside the bunkroom roll the day over on a day with a morning line, so Galley's "Talk to Aksel" branch and Scene.spend's night-lines display were unexercised. Three FakeGame tests now pin them: the row is absent while he is across the bay, talking to him costs no watch, and an evening meal cooked on day four turns the day, eats the store and shows the ice line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (one pass, anchored on CI run 43687847097: test 3.8, test 3.12 and docker all green on 3848261):
Judgment notes:
All items PASS or N/A. No changes are needed before merge. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/scene-tests-galley-aksel-and-night
branch
November 15, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle: tests only, with no production code changed.
tests/test_scenes.py::test_aksel_is_only_at_the_galley_table_once_he_is_at_the_station: the galley offers no "Talk to Aksel" row while he is in the hut.tests/test_scenes.py::test_talking_to_aksel_at_the_galley_table_costs_no_watch: with Aksel at the station, the galley conversation runs (his "Your galley" line) and costs no watch, the same as every other conversation in the game.tests/test_scenes.py::test_an_evening_spent_in_the_galley_shows_what_the_night_brought: an evening action outside the bunkroom on day four rolls the night over. The day turns, four rations are eaten, and the day-five ice line fromwinter.DAY_LINESis shown throughScene.spend.Before this PR,
scenes/galley.py:90-91(the Aksel branch) andscenes/base.py:76(spendshowing the night's lines) were never executed by the suite: every playthrough ends its days with "Turn in". Both are now covered, andgalley.pyreaches 100% line coverage.No tracking issue: the gap was found during triage with
pytest --cov.Open issue #18 was skipped this cycle. It is waiting on a story decision among the directions it lists, and only the author can make that decision (see the existing comment on the issue).
Test plan
python3 -m pytest: 193 passed (190 before)python3 -m black --check tests/test_scenes.py: cleanFULL_RUNandtests/test_endings.pyunchanged and passingThis PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson