Skip to content

test: pin Aksel at the galley table and a night that falls outside the bunkroom - #53

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/scene-tests-galley-aksel-and-night
Nov 15, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/scene-tests-galley-aksel-and-night

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

Stage B (unit-test expansion) cycle: tests only, with no production code changed.

  • tests/test_scenes.py::test_aksel_is_only_at_the_galley_table_once_he_is_at_the_station: the galley offers no "Talk to Aksel" row while he is in the hut.
  • tests/test_scenes.py::test_talking_to_aksel_at_the_galley_table_costs_no_watch: with Aksel at the station, the galley conversation runs (his "Your galley" line) and costs no watch, the same as every other conversation in the game.
  • tests/test_scenes.py::test_an_evening_spent_in_the_galley_shows_what_the_night_brought: an evening action outside the bunkroom on day four rolls the night over. The day turns, four rations are eaten, and the day-five ice line from winter.DAY_LINES is shown through Scene.spend.

Before this PR, scenes/galley.py:90-91 (the Aksel branch) and scenes/base.py:76 (spend showing the night's lines) were never executed by the suite: every playthrough ends its days with "Turn in". Both are now covered, and galley.py reaches 100% line coverage.

No tracking issue: the gap was found during triage with pytest --cov.

Open issue #18 was skipped this cycle. It is waiting on a story decision among the directions it lists, and only the author can make that decision (see the existing comment on the issue).

Test plan

  • python3 -m pytest: 193 passed (190 before)
  • python3 -m black --check tests/test_scenes.py: clean
  • FULL_RUN and tests/test_endings.py unchanged and passing

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

…e bunkroom

No playthrough talked to Aksel in the galley, and none let an evening
action outside the bunkroom roll the day over on a day with a morning
line, so Galley's "Talk to Aksel" branch and Scene.spend's night-lines
display were unexercised. Three FakeGame tests now pin them: the row is
absent while he is across the bay, talking to him costs no watch, and an
evening meal cooked on day four turns the day, eats the store and shows
the ice line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (one pass, anchored on CI run 43687847097: test 3.8, test 3.12 and docker all green on 3848261):

  • Scope: PASS. One file changed (tests/test_scenes.py, +43 lines including imports). No production code or docs touched.
  • Tests-new: PASS. No new public methods. Three new tests cover the previously unexecuted scenes/galley.py:90-91 and scenes/base.py:76. pytest --cov shows galley.py at 100%.
  • Tests-fix: N/A. Not a bug fix. As a substitute signal, a mutation check was run locally: replacing spend's showDialogue with pass made test_an_evening_spent_in_the_galley_shows_what_the_night_brought FAIL (1 failed, 14 passed), and restoring it made the test pass.
  • Sibling structure: PASS. The tests use the file's existing scene() / FakeGame / ScriptedUI pattern and its naming style, and sit next to the other galley tests.
  • Sibling renames: N/A. Nothing was renamed.
  • Docs: PASS. The rows in the documentation table are unaffected: README test counts are not stated, and no behaviour changed.
  • Issue resolution: N/A. There is no Closes, and the gap was found during triage.
  • CI: PASS. Green on the PR head.
  • Knowledge-gated / Calendar in one place / Save format / One RNG / Vendored client: N/A. Tests only. The new test reads the ice line from winter.DAY_LINES rather than copying the text.
  • Solvable: PASS. FULL_RUN and tests/test_endings.py were not modified and pass.

Judgment notes:

  • tests/test_scenes.py (night test): game.ui.dialogues[-1] == DAY_LINES[ICE_SAFE_DAY] assumes the ice line is the only night line on day five, which holds because _theSchedule stays silent unless TOLD_DOV is set. If a future calendar event lands on day five, this assertion will need in instead of ==. That is acceptable for a characterization test.
  • tests/test_scenes.py (Aksel talk test): this test pins the current design that conversations are free. That matches the office, radio and shed, which also return self.after() without spend.

All items PASS or N/A. No changes are needed before merge.

This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit a73c77c into main Nov 15, 2026
3 checks passed
@dmccoystephenson
dmccoystephenson deleted the feature/scene-tests-galley-aksel-and-night branch November 15, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant