Repository navigation
test: pin a save in an unknown place, an uncopyable damaged save and closing the log unread - #56
Merged
Merged
Conversation
…closing the log unread Three paths no test reached: a save whose location the game no longer has resumes in the galley with its facts kept; a damaged save that cannot be copied aside says so and leaves no backup behind; and opening the station log and closing it unread costs no watch and teaches nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (internal; not an independent review):
Finding to note:
Verdict: a test-only PR with CI green and no paths on the do-not-auto-merge list. It is eligible to merge. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle. The only open issue, #18, is waiting on a story decision (see its comment), so it was not picked up. A documentation accuracy sweep was run first and found no drift: the README's counts (18 facts, a 5-fact trail, 20 days, 3 watches, 7 places, 3 endings, 15 days of store, 3 from the depot and 2 from a seal), the env-var names, the usage-reporting events and
schemas/save.jsonwere each checked againstfacts.py,state.py,config.py,usageReporting.pyandState.toDict, and all of them match.Three behaviour-bearing paths that no test reached before are now pinned. Only tests change:
game.py— a save in a place the game no longer has (_runGameLoop's fallback): the save loads without counting as a failed load, resumes in the galley, and keeps the facts already learned.game.py— a damaged save that cannot be copied aside (_preserveDamagedSave'sOSErrorbranch): the player is told "It could not be copied aside.", no.damaged-*file is left behind, and a fresh winter starts.scenes/office.py— closing the station log unread: costs no watch and teaches no fact.After this change,
game.pyandscenes/office.pyare both at 100% statement coverage.Test plan
python3 -m pytest: 196 passed (193 before, plus 3 new)pytest --cov:game.pyandscenes/office.pyat 100%FULL_RUNandtests/test_endings.pyrun unmodified.black --checkcould not be run in this sandbox. No changed line goes past black's 88-column limit, and CI does not enforce black.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson