Repository navigation
List backup with several names in interactive mode's command list - #70
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (Copilot reviewer could not be requested:
Out-of-diff observation: Judgment call (non-blocking): the descriptions keep the existing verb "Backup" (noun form) rather than "Back up", to limit the change to what #69 names. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
help, now showbackup <user/org> [user/org2] ...instead ofbackup <user/org>. Since Back up each name given to the interactive backup command #68 the command backs up every name it is given, andCOMMANDS.md,USER_GUIDE.mdand the command's own usage hint already say so; the on-screen list was the only place still suggesting a single name. The other rows are realigned to the wider column.BackupCommandLineRunnerTestgains one test for the start banner and one for thehelpoutput (sliced fromAvailable Commands:so the banner cannot satisfy it). The existinghelprow assertion is updated to the realigned spacing.CHANGELOG.mdrecords the change under[Unreleased]→Fixed.No documentation file other than
CHANGELOG.mdneeded changing:COMMANDS.mdandUSER_GUIDE.mdalready list the multi-name form, and no configuration, flag or endpoint changed. The README GIF (docs/images/gh-backup-interactive.gif) shows the old banner, but it is a dated recording of a real 2026-10-18 run, so it was left as is.Deferred: #8 (missing
LICENSE) still needs the maintainer to choose the license, copyright holder and year.Test plan
mvn test: 227 tests run, 0 failures, 0 errors, 1 skipped (pre-existing)BackupCommandLineRunner.javachange stashed, the two new tests and the updatedhelptest fail (3 failures); with it restored, all 40BackupCommandLineRunnerTesttests passBuildgreen on the PR headCloses #69
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson