Repository navigation
docs: describe what the publish smoke test actually imports - #73
Merged
Merged
Conversation
RELEASING.md called the wheel smoke test a "canonical import", but it only imports the package, whose lazy __getattr__ never loads graphik.py or pygame. State the narrower check and point at #46. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use an em dash like the rest of RELEASING.md, and name what a passing wheel could still be missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff and CI run 43371860193):
Finding outside the diff, noted only: the README license block reads "Copyright © 2022–2025", while This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASING.mddescribed the publish workflow's wheel smoke test as "install + canonical import + version check". The canonical import documented in the README andRELEASING.mdisfrom preponderous.graphik import Graphik, but the step in.github/workflows/publish.ymlruns onlyimport preponderous.graphikplus a__version__check. Becausepreponderous/graphik/__init__.pyresolvesGraphiklazily through a module-level__getattr__, neithergraphik.pynorpygameis loaded by that step..github/workflows/*is on the do-not-auto-merge list, and release: publish.yml's wheel smoke test never imports Graphik, so a wheel missing graphik.py would still publish #46 is left open for that fix.This is a Stage A (documentation accuracy) cycle. No tracking issue exists for the doc wording itself; the gap was found during the sweep and is related to, but does not close, #46.
Skipped issues
All open issues were deferred this cycle:
.github/workflows/*(do-not-auto-merge), or in the release/tagging process.Test plan
publish.yml(smoke-test step) andsrc/main/python/preponderous/graphik/__init__.py(lazy__getattr__, imports only_version).Testworkflow green on this PR. Only Markdown is changed, so no code path is affected. Local pytest could not be run in this session's sandbox, so the result is recorded as UNVERIFIED-not-applicable.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson