Repository navigation
Say which thread the Logger runs on, and that CI runs UBSan - #22
Merged
Merged
Conversation
The README now states what the header comment on Logger already did: a failed delivery is mentioned on the client's thread, a full queue on the thread that called report. The CI description names the UndefinedBehaviorSanitizer leg the address,undefined job runs, and the TIMEOUT_SECONDS comment no longer says it is the most close() can wait, which close(seconds) has made untrue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline in a headless dispatch; not an independent review):
Judgment call flagged: Do-not-auto-merge paths: none touched (no workflow, Makefile, CMakeLists, curl/spawn code, version or wire-format change). This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage A documentation accuracy sweep: every claim in
README.mdand the comments intrace_client.hppwas checked against the code,Makefile,CMakeLists.txtand.github/workflows/build.yml. Three drifts were found and fixed; no code behavior is changed.Loggeris called on. The header'sLoggertypedef comment already said it (failed deliveries on the client's thread viadeliver, a full queue on the reporting thread viaenqueue); the README did not, and a program supplying a non-thread-safe logger needs to know.linux-sanitizersjob runsthreadandaddress,undefined; UndefinedBehaviorSanitizer is now named.TIMEOUT_SECONDScomment — said it is "the most close() waits for queued reports", whichclose(seconds)/close(INFINITY)make untrue; it now says "by default". Comment-only change intrace_client.hpp.Everything else checked held: queue capacity 256, 5 s timeout, 255-byte limits, 32 tags, opt-out values and precedence, all four
disabledReason()strings, the curl command line and config lines, theUser-Agentversion (0.3.0 in all three places), and the CMake test binary path.No tracking issue — gap found during triage.
Deferred issues
TRACE_CLIENT_CURLignored on Windows whenSystem32\curl.exeexists) — awaits the owner's decision, and touches thecurl.exelookup on the do-not-auto-merge list.The README still says every event carries
versionand thatTRACE_CLIENT_CURLoverrides the executable; those statements are the subject of #21 and #1 and were left as they are.Test plan
make clean && make test(g++, C++11):59 tests, 0 failed checks, 59 entries intests[]Buildgreen on the PR headThis PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson