Repository navigation
Test which thread the Logger is called on - #25
Merged
Merged
Conversation
The README and the Logger typedef both say a failed delivery is mentioned on the client's own thread and a full queue on the thread that called report, and nothing asserted either. Log now records the calling thread with each line. Closes #23 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clang rejects the explicit capture of a constant under -Werror (-Wunused-lambda-capture); a default capture builds on every compiler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline in a headless dispatch; not an independent review):
Findings:
Do-not-auto-merge paths: none touched (no workflow, Makefile, CMakeLists, curl/spawn code, version or wire-format change). This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B test expansion: the Logger's threading promise is now asserted. No production code is changed.
aFailedDeliveryIsLoggedOnTheClientsOwnThread— both failed-delivery messages (trace server answered 500andcould not deliver, against a closed port) are checked not to arrive on the thread that calledreport.aFullQueueIsLoggedOnTheThreadThatCalledReport— a flood pastQUEUE_CAPACITYfrom a dedicated thread is checked to log everyqueue fullmessage on that thread, so it cannot be confused with the thread that built the client.Lognow records the calling thread beside each line, with acountOn(needle, thread)lookup. Both tests observe through the stub server and the Logger, and no new sleeps are added.Closes #23
Deferred issues
TRACE_CLIENT_CURLignored on Windows whenSystem32\curl.exeexists) — awaits the owner's decision, and touches thecurl.exelookup on the do-not-auto-merge list.report()hangs when a Logger reports while the queue is full) — found while this PR was being prepared and filed for a separate implementation cycle, since a test-expansion cycle does not change production code.Test plan
make clean && make test(g++, C++11):61 tests, 0 failed checks, up from 59, with 61 entries intests[]expected [0] got [1]twice, andexpected [511] got [0])Buildgreen on the PR head, including bothlinux-sanitizerslegs,macosandwindows: all 11 jobs printed61 tests, 0 failed checksmake test-libcurland clang++ were not run locally; both were covered by CI.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson