Repository navigation
Stop curl expanding a base URL into several requests - #29
Merged
Merged
Conversation
curl's URL globbing happens after the config line is parsed, so quoting
does not reach it: a base URL with {} or [] became several requests, to
paths the program never named, and their statuses ran together into
one that could not be read. libcurl does not glob, so only the default
transport did this.
Closes #28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric, scored against commit 7d37d6f:
Limits of this verification:
Merge is held for the owner, as the PR description explains. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globoffline is added to the curl config, directly afterurl. A base URL containing{}or[]is now sent as one request to that literal path, rather than being expanded by thecurltool into several requests.README.md("How a report is sent") namesgloboffalongsideproto.curl -q --silent --config -), and no program-supplied value is added to the config.Closes #28
Test plan
aBaseUrlIsNeverExpandedIntoSeveralRequestswas added and registered intests[].make test:74 tests, 3 failed checks(2 requests, path/a/api/metrics, 1Loggerline).make test(g++, C++11):74 tests, 0 failed checks.curlConfigFixesEveryOptionAndQuotesEveryValuewas updated for the new line.Merge
Autonomous merge is held. This diff adds to the curl config, which is the security boundary the README documents.
globoffis not literally listed among the do-not-auto-merge paths, but it is the same kind of change as the listedprotoline, so the decision is left to the owner.Issues not picked this cycle
curl.exelookup order, which is on the do-not-auto-merge list.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
drafted by Claude on behalf of Daniel Stephenson
🤖 Generated with Claude Code