Repository navigation
Name isEnabled() in the README's "Turning it off" - #31
Merged
Merged
Conversation
The README documented disabledReason(), environmentOptsOut() and installId() but never isEnabled(), and did not say the two status methods part ways after close(). Closes #30 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 42447424649, all 11 jobs green):
Local anchor: UNVERIFIED-not-applicable (README-only diff); CI on the head SHA serves as the anchor. Do-not-auto-merge path check: This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.isEnabled()(whetherreportwill send anything) and stating how it differs fromdisabledReason()afterclose():isEnabled()turns false whiledisabledReason()is unchanged (still empty for a client that was reporting).trace_client.hpp(isEnabled()returnscurrent(), documented "False after close()";disabledReason()documented "Unchanged by close()") and againstcloseIsPromptAndIdempotentintest/test_trace_client.cpp, which asserts both.Closes #30
Deferred issues
TRACE_CLIENT_CURLignored on Windows when System32 curl exists) — changes thecurl.exelookup, a do-not-auto-merge security boundary; left for an implementation cycle with human review.Test plan
Buildgreen on the PR head.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson