Repository navigation
Test that a blank name is never mentioned to the Logger - #32
Merged
Merged
Conversation
The README promises a report with an empty or blank name is ignored "without a mention to the Logger", but reportIgnoresABlankName attaches no Logger. The new test sends blank names through every report overload alongside one real report to a server answering 500, so the Logger is seen to be listening and hears only that one drop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against CI run 43152682886 on the PR head and the diff):
Observation, for judgment: test/test_trace_client.cpp:806 — Summary: this PR adds test coverage only. It is green on every platform job, and no path on the do-not-auto-merge list is touched. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aBlankNameIsNeverMentionedToTheLoggeris added totest/test_trace_client.cppand registered inmain()'stests[]table.reportpromises" → "Fits the server's limits") states that a report whose name is empty or blank "is ignored, without a mention to theLogger". Only the first half of that promise was asserted:reportIgnoresABlankNamechecks that nothing reaches the server, but noLoggeris attached in it.reportoverloads (name; name + tags; name + value + tags), using every ASCII space character, followed by one real report to a stub server answering500. Exactly oneLoggerline is expected — theanswered 500drop forstartup— which shows theLoggerwas listening and that nothing was produced for the blank names.This is a Stage B (unit-test expansion) cycle. A Stage A documentation sweep was run first, with
README.mdchecked againsttrace_client.hpp,Makefile,CMakeLists.txtand.github/workflows/build.yml; no drift was found beyond what the two open issues already track.Deferred issues
TRACE_CLIENT_CURLignored on Windows whenSystem32\curl.exeexists) — an owner decision is awaited, and thecurl.exelookup it touches is on the do-not-auto-merge list.No tracking issue — gap found during triage.
Test plan
make test(g++, C++11,-Wall -Wextra -pedantic -Werror):75 tests, 0 failed checks(74 onmain, plus the one added here)Build: linux (g++/clang++ × c++11/17/20), linux-libcurl, linux-sanitizers (thread; address,undefined), macos, windows. clang++ is not installed locally, so CI is relied on for that compiler.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson