Repository navigation
Test which tags count as an event's own version or install - #33
Conversation
An empty value is a tag and wins over the program's version or the configured installation ID, unlike a null one. Keys are matched exactly: "Version", "Install" or " version" are ordinary tags and do not displace either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Self-review rubric (posted as a comment; it is not an independent review)
One observation outside the diff, for the maintainer: Local This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
Summary
Stage B (unit-test expansion) cycle: tests only, no production change. Four characterization tests pin down which tag counts as an event's own
versionorinstall, a rule the README states ("An event that passes its ownversiontag keeps it") without saying how a key is matched:Report_AnEmptyVersionTagStillWinsOverTheProgramVersion:{"version": ""}is sent as is, and the program's version is not added. A null value is already covered and behaves differently (it is no tag at all).Report_OnlyTheExactLowercaseVersionKeyCountsAsTheEventsOwn:Versionandversionare ordinary tags, and the program's version is still added.WithVersioncompares keys with==and does not trim them.Report_AnEmptyInstallTagStillWinsOverTheConfiguredIdandReport_OnlyTheExactLowercaseInstallKeyCountsAsTheEventsOwn: the same two cases forWithInstalland the configured installation ID.Each test drives a real client against
StubServerand asserts the exact body afterClose().Triage notes
README.md, the class and member XML docs, both csproj files andbuild.ymlwere checked againstTraceClient.cs, and no drift was found, so this cycle adds tests instead.User-Agent). All three change the wire format or the client's behaviour, so each needs a maintainer decision before any implementation.Test plan
Buildworkflow green on ubuntu-latest (net8.0)Buildworkflow green on windows-latest (net8.0 + net48)WithVersion→WithInstall→Jsondotnetcould not be run in the dispatch sandbox, so local verification is UNVERIFIED and the CI matrix on the PR head is the gate.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson