Repository navigation
Test a blank key's disabled reason and an empty install ID file - #35
Merged
dmccoystephenson merged 1 commit intoNov 12, 2026
Merged
Conversation
The README promises that a blank key disables reporting with the reason "no key", and that an install ID file holding no valid line is replaced with a fresh ID. Neither case had a test of its own: a blank key was only checked for sending nothing, and the replaced file held junk lines rather than nothing at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 43143171274):
Judgment note: the empty-file test writes into a fresh per-test temp directory and is cleaned up by the fixture's This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/test-blank-key-and-empty-install-file
branch
November 12, 2026 02:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle: two promises made in the README are given tests of their own. No production code is changed.
DisabledReason_TreatsABlankKeyAsNoKey: the "Turning it off" table says "No key, or a blank one" yieldsno key. A blank key was previously checked only for sending nothing (DisabledClient_SendsNothing), never for the reason a program prints. Covers"", spaces, and"\t\n".InstallIdFromFile_ReplacesAnEmptyOrBlankFileWithAFreshId: the README says a file that "holds no such line" gets a new random ID. The existing test covered a file of junk lines; a zero-byte or whitespace-only file (touched by hand, or cut off mid-write) had no test. The fresh ID is asserted to be written and reused.No tracking issue — gaps found during triage.
Test plan
Buildworkflow green on ubuntu-latest (net8.0)Buildworkflow green on windows-latest (net8.0 + net48)The local
dotnetSDK was not available in the dispatch sandbox, so the CI matrix on the PR head is the test anchor.Skipped issues
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson