Repository navigation
Test escaping and untrimmed passthrough in every JSON string field - #37
Merged
dmccoystephenson merged 1 commit intoNov 14, 2026
Merged
Conversation
Quote was only exercised on tag values and bare control characters. Pin that the application, name and tag keys are escaped the same way, that DEL and U+2028/U+2029 go out unescaped (valid JSON), and that Report sends an event's name, tag keys and tag values untrimmed, unlike the application, version and key the constructor trims. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head of
Local run: UNVERIFIED. Observation: Do-not-auto-merge check: the only path touched is This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/test-escaping-and-untrimmed-fields
branch
November 14, 2026 02:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle, scoped to JSON string handling. Test-only; no production code is changed.
Quote_WritesDeleteAndTheUnicodeLineSeparatorsAsIs— U+007F, U+2028 and U+2029 are written unescaped. JSON only requires U+0000–U+001F to be escaped, so this output is valid.Json_EscapesTheApplicationNameAndTagKeysLikeTagValues— quotes, backslashes and newlines in the application, the name and tag keys are escaped. Until now only tag values and bare control characters were exercised.Report_SendsTheNameAndTagsUntrimmed— end to end: an event's name, tag keys and tag values are sent exactly as given. The constructor's trimming covers only the application, version and key (Constructor_TrimsTheBaseUrlApplicationAndKey).A Stage A documentation sweep was run first (README sections, class/member XML docs, csproj comments,
build.yml) and found no drift against the source, so the cycle fell back to Stage B.Deferred issues
All three open issues are maintainer-gated contract changes, so none was picked up:
User-Agenthandling, which is part of the wire format.coalescedtag.Test plan
Build, ubuntu-latest (net8.0): green, with the three new tests in the totalBuild, windows-latest (net8.0 + net48): greendotnet testcould not be run because the dispatch sandbox does not allowdotnet. The CI matrix on the PR head is the gate for this PR (UNVERIFIED locally).No tracking issue: the gap was found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson