Repository navigation
Test that an event's own overlong version or install tag drops it - #38
Conversation
An event's own version and install tags win over the configured ones, but no test covered what happens when that tag is past MaxLength. Pin the current behaviour: the event is dropped and logged as "tag version longer than 255 characters" (or "tag install ...") rather than sent with the program's version or configured ID in its place, while a tag exactly at the limit is still sent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Self-review rubric (anchored on CI run 43688172902 on the PR head):
Repo-specific: No dependencies PASS (csproj untouched); Single file PASS ( Judgment note: the tests pin that an event's own oversize Local anchor: UNVERIFIED, because no usable This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
Summary
Stage B (unit-test expansion) cycle: two characterization tests are added for a branch that had no coverage.
An event's own
versionandinstalltags win over the program's version and the configured installation ID. No test pinned what happens when that tag is longer thanMaxLength. The current behaviour is now locked in:Report_AnEventsOwnVersionTagPastTheLimitDropsTheEventRatherThanFallingBack(TraceClientTest.cs): a 256-charversiontag drops the event, logged as[trace] dropped startup: tag version longer than 255 characters. The program's version is not sent in its place. A 255-char tag is still sent.Report_AnEventsOwnInstallTagPastTheLimitDropsTheEventRatherThanFallingBack(InstallIdTest.cs): the same forinstallwith a configured ID.No production code or documentation is changed. The README sentence "An event that passes its own
versiontag keeps it" already agrees with this behaviour.No tracking issue — gap found during triage.
Deferred issues
All three open issues are contract changes that need a maintainer's decision, so none was picked:
Drain/Closebehaviour change.User-Agent): wire-format change; the issue asks which option to take.Test plan
Buildgreen on ubuntu-latest (net8.0)Buildgreen on windows-latest (net8.0 + net48)The local anchor could not run because no
dotnetSDK is usable in the dispatch sandbox, so this is UNVERIFIED locally. The CI matrix on the PR head is the gate.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson