Repository navigation
Pin a second tags: block and how the tags: line is matched - #47
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff and CI on head a287efa):
Repo-specific:
Judgment call, folded in here because it is not anchored to a changed line:
Summary: a test-only PR that pins two parser behaviours no test drove before. CI is green, and no do-not-auto-merge path is touched. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage B — unit-test expansion (server-wide config: the
tags:line and a secondtags:block).Summary
Two characterization tests are added to
TraceClientTest. Production code is unchanged.serverWideTags_aSecondTagsBlockAddsToTheFirstAndTheFirstEntryOfAKeyWins: a file with twotags:blocks is read as one merged set of tags. Each block takes its own entry indent, becauseparseServerWideConfigresetsentryIndentat everytags:line. A key already read from an earlier block is not replaced, becauseaddServerWideTagkeeps the first entry. No test drove a second block before.serverWideTags_theTagsLineIsCaseSensitiveAndAllowsSpaceBeforeTheColon:TAGS_LINE(^tags\s*:\s*(#.*)?$) acceptstags :. It rejectsTags:and atags:line that carries a value. Under a line that does not open a block, an indentedenabled: falseis outside anytags:block, so it is the switch. That matches theparseServerWideConfigJavadoc ("the firstenabled:line outside atags:block is the switch").Both tests assert the current behaviour. Neither one changes it. The README and the Javadoc describe "a
tags:block" and do not say what a second block does. The merge behaviour is now pinned, and no documentation change is made in this PR.Skipped issues
Every open issue was left out for one reason: each needs a maintainer decision on the opt-out contract or the tag rules, which is a do-not-auto-merge area.
MAX_TAGS(wire format and tag limit).Test plan
mvn -B verifyrun locally on Java 21:Tests run: 113, Failures: 0, Errors: 0, Skipped: 0. The surefire report includes both new tests.build (8),build (17),build (21)green on the PR head.No tracking issue; this gap was found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson