Repository navigation
Log and document the report close() drops from a full queue - #43
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff and command output):
Judgment note: No FAIL items remain. Do-not-auto-merge paths (workflows, This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close()on a full queue removes the oldest queued report to make room for the stop sentinel. That drop was the only one not logged. It is now logged atDEBUGon thetracelogger as[trace] queue full at close, dropped <body>, which matches the README's promise that drops are "logged atDEBUGon thetracelogger, otherwise not at all".close()docstring and the README's "close()drains" row now say that a full queue costs the oldest queued report. Before this, both said only that queued reports get the timeout to be sent and are not discarded.test_the_report_close_drops_from_a_full_queue_is_logged_at_debug.Closes #42
Test plan
python3 -m unittest: 79 tests ran, OK (local, Python 3)trace_client.pychange stashed, the new test FAILS; with it restored, the test PASSEStest (3.8),test (3.10),test (3.12)greenJava parity
No Java-visible behavior changed. The change is a local DEBUG log line plus documentation. The wire format, opt-out values and
disabled_reasonstrings are untouched.Deferred
tagsalways holds at leastversion" promise at theMAX_TAGScap, and the change has to be made together with trace-client-java.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson