Rename "Parallax corrected Cubemaps" to "General" - #214
Merged
Conversation
OrsellGit
requested changes
Aug 21, 2026
OrsellGit
left a comment
OrsellGit
left a comment
Contributor
There was a problem hiding this comment.
Just fix the title capitalization then this is good to go.
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "title": "Parallax Corrected Cubemaps", | |||
| "title": "general", | |||
Contributor
There was a problem hiding this comment.
This should be "General", but not the folder, just the title.
Contributor
Author
|
should be done |
Member
|
Is this PR correct? The diff looks odd, where it shows a bunch of files removed. Was the goal to remove these or move them elsewhere? |
Contributor
|
Yeah I am confused, all that was needed was the title casing to be fixed. I dont know why this other commit was done. |
Contributor
Author
|
the commit remove the PCC tutorial in the materials page i remove it because there already a recent pr (that was merge) that add it into the graphics(previously call lightings) tabs but i guess i can revert it if it's problematic it's just to avoid do to another PR for this |
OrsellGit
approved these changes
Aug 22, 2026
OrsellGit
force-pushed
the
rename-pcc-page2
branch
from
August 22, 2026 00:54
81961ab to
8e92ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.