Give create-form the builder's defaults: anti-spam on and an email action by vivi-the-going-merry[bot] · Pull Request #3600 · Strategy11/formidable-forms

vivi-the-going-merry · 2026-10-21T02:26:09Z

Fixes Strategy11/formidable-pro#6859

Broken: forms made through the create-form ability had anti-spam off and no email action. Forms made in the builder get both.

Changed

FrmAbilitiesFormsController::execute_create_form() sets options[antispam] = 1 unless the caller passed options.antispam, so an explicit 0 stays off.
It then calls FrmFormsController::create_default_email_action(), skipped when is_template or parent_form_id is set. That method is now public instead of copied, and still runs the frm_create_default_email_action filter.
Builder code path is unchanged apart from the method's visibility.

Verified: Lite's local PHPUnit can't run here, so CI is the red/green. Test-only commit: the new defaults test failed on all 4 PHPUnit jobs (Anti-spam should be on by default, 0 is not 1). With the fix, all 4 pass, plus PHPCS, PHPStan, Psalm, Mago, Rector and PHP CS Fixer.

The other three new tests (explicit antispam = 0, template and child form skip, filter returning false) pass before and after; they guard the edges of the change. Not run end to end through an MCP client.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-21T02:26:16Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Strategy11/formidable-forms/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 8b64f2dd-3a9d-426c-b380-b6e519fbca5e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-10-21T02:27:24Z

DeepSource Code Review

We reviewed changes in 1927ae3...6f81b26 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Oct 21, 2026 2:30a.m.	Review ↗
JavaScript		Oct 21, 2026 2:30a.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-10-21T02:27:44Z

+	public function test_create_form_defaults_to_antispam_and_one_email_action() {
+		$created = $this->execute( 'create-form', array( 'name' => 'Form With Defaults' ) );
+
+		$this->assertNotWPError( $created );


Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+		$this->assertNotWPError( $created );
+
+		$form = FrmForm::getOne( $created['id'] );
+		$this->assertSame( 1, (int) ( $form->options['antispam'] ?? 0 ), 'Anti-spam should be on by default.' );


Call to an undefined method test_FrmAbilitiesFormsController::assertSame()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+
+		$form = FrmForm::getOne( $created['id'] );
+		$this->assertSame( 1, (int) ( $form->options['antispam'] ?? 0 ), 'Anti-spam should be on by default.' );
+		$this->assertCount( 1, FrmFormAction::get_action_for_form( $created['id'], 'email' ), 'The default email action should be created.' );


Call to an undefined method test_FrmAbilitiesFormsController::assertCount()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+			)
+		);
+
+		$this->assertNotWPError( $created );


Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+		$this->assertNotWPError( $created );
+
+		$form = FrmForm::getOne( $created['id'] );
+		$this->assertSame( 0, (int) ( $form->options['antispam'] ?? 1 ), 'An explicit antispam of 0 should be kept.' );


Call to an undefined method test_FrmAbilitiesFormsController::assertSame()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+		$this->assertCount( 0, FrmFormAction::get_action_for_form( $template['id'], 'email' ), 'A template should not get an email action.' );
+
+		$parent = $this->execute( 'create-form', array( 'name' => 'Parent Form' ) );
+		$this->assertNotWPError( $parent );


Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+				'parent_form_id' => $parent['id'],
+			)
+		);
+		$this->assertNotWPError( $child );


Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+			)
+		);
+		$this->assertNotWPError( $child );
+		$this->assertCount( 0, FrmFormAction::get_action_for_form( $child['id'], 'email' ), 'A child form should not get an email action.' );


Call to an undefined method test_FrmAbilitiesFormsController::assertCount()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+
+		remove_filter( 'frm_create_default_email_action', '__return_false' );
+
+		$this->assertNotWPError( $created );


Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-21T02:27:44Z

+		remove_filter( 'frm_create_default_email_action', '__return_false' );
+
+		$this->assertNotWPError( $created );
+		$this->assertCount( 0, FrmFormAction::get_action_for_form( $created['id'], 'email' ), 'The filter should be able to stop the default email action.' );


Call to an undefined method test_FrmAbilitiesFormsController::assertCount()

The method you are trying to call is not defined, which can result in a fatal error.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

franky-the-going-merry

Approve. create-form now matches the builder on both points the issue lists, and nothing else changed.

Reproduced live (Playground, Lite only), base vs this PR, calling execute_create_form() as an admin:

Input	Base	PR
no options	antispam 0, 0 email actions	antispam 1, 1 email action
`options.antispam = 0`	0, 0 actions	0 kept, 1 action
`options.antispam = '0'`	'0', 0 actions	'0' kept, 1 action
`options.submit_value = 'Go'`	antispam 0	antispam 1, `submit_value` still 'Go'
`is_template = 1`	0 actions	0 actions
`parent_form_id` set	0 actions	0 actions

The test-only commit (53f3380) failed PHPUnit on 7.4 and the other jobs were cancelled behind it; at the head all four PHPUnit jobs, Psalm and the syntax checks pass. Source read: the builder (build_new_form()) sets antispam to 1 and calls the same create_default_email_action(), so this is the shared path, not a copy, and the frm_create_default_email_action filter still applies. Making the method public is the only builder-side change.

Not run: the filter-returning-false test locally (CI covers it), an MCP client end to end, Pro.

Crabcyborg

🚀

Add failing tests for create-form defaults (antispam, email action)

53f3380

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

vivi-the-going-merry Bot added the run tests label Oct 21, 2026

deepsource-io Bot reviewed Oct 21, 2026

View reviewed changes

Give create-form the builder's anti-spam and email action defaults

6f81b26

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

vivi-the-going-merry Bot added the run analysis label Oct 21, 2026

vivi-the-going-merry Bot marked this pull request as ready for review October 21, 2026 02:36

vivi-the-going-merry Bot added the franky-review label Oct 21, 2026

franky-the-going-merry Bot added the franky-working Franky is actively reviewing this label Oct 21, 2026

franky-the-going-merry Bot approved these changes Oct 21, 2026

View reviewed changes

franky-the-going-merry Bot added vivi-pickup and removed franky-review franky-working Franky is actively reviewing this vivi-pickup labels Oct 21, 2026

Crabcyborg approved these changes Oct 22, 2026

View reviewed changes

Crabcyborg merged commit 59434e9 into master Oct 22, 2026
75 of 76 checks passed

Crabcyborg deleted the fix/issue-6859-create-form-defaults branch October 22, 2026 12:59

Crabcyborg added this to the 7.1 milestone Oct 22, 2026


		remove_filter( 'frm_create_default_email_action', '__return_false' );

		$this->assertNotWPError( $created );

Conversation

vivi-the-going-merry Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertSame()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertCount()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertSame()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertCount()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertNotWPError()

Uh oh!

deepsource-io Bot Oct 21, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmAbilitiesFormsController::assertCount()

Uh oh!

franky-the-going-merry Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Crabcyborg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vivi-the-going-merry Bot commented Oct 21, 2026 •

edited

Loading

coderabbitai Bot commented Oct 21, 2026 •

edited

Loading

deepsource-io Bot commented Oct 21, 2026 •

edited

Loading