Payments admin JS: keep other gateways' Capture row hidden, show Refunded status without reload by vivi-the-going-merry[bot] · Pull Request #3616 · Strategy11/formidable-forms

vivi-the-going-merry · 2026-10-23T05:51:30Z

Closes Strategy11/formidable-pro#6899 (the add-on copy of the refund fix is Strategy11/formidable-payments#178).

What was broken

Collect a Payment with PayPal or Square selected: switching Payment Type to Recurring and back to One-time showed the Stripe-only Capture Payment row.
On a payment's page, Refund → Confirm left Status on "Completed" until reload.
The Capture Payment row compared 'stripe' !== $selected_gateway, but $selected_gateway is an array, so the row was hidden on load even with Stripe selected.

What changed

frmtrans_admin.js: after switching back to One-time, rows for another gateway are hidden again.
capture-payments-upsell.php: uses in_array( 'stripe', (array) $selected_gateway, true ).
Payment page: Status cell gets frm-payment-status; frm_trans_vars.refunded carries the label; runAjaxLink() sets it after a successful refund response.
Two PHPUnit cases in test_FrmTransLiteActionsController.php.

The add-on's bundled copy (formidable-payments) has the same refund-status gap and is not changed here.

How it was verified

PHPUnit: both new tests fail on master and pass on the branch (red shows as the masked SERIALIZATION_FORMAT error, one failure each). All tests/phpunit/stripe files pass.
Live on Lite + Pro preview env, PayPal selected, Recurring → One-time: master row visible, branch none. Stripe selected: row stays visible on both.
Refund status: ran the script in the browser with the refund request stubbed to Lite's success response. Master leaves "Completed", branch shows "Refunded". Not run against a real Stripe refund.

Before (master):

After:

🤖 Generated with Claude Code

…funded status without reload Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-23T05:51:38Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Source mode: Auto
Repository: Strategy11/formidable-forms
Branch: master
File: .coderabbit.yaml
Commit: a0b9742
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 0d69229f-459a-459d-9232-6b2db5091189

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-10-23T05:52:24Z

DeepSource Code Review

We reviewed changes in a0b9742...6b906e3 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Oct 23, 2026 5:51a.m.	Review ↗
JavaScript		Oct 23, 2026 5:51a.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-10-23T05:52:33Z

@@ -70,6 +70,33 @@ public function test_maybe_use_decimal() {
 		$this->assertSame( '111.500', $amount );


Call to an undefined method test_FrmTransLiteActionsController::assertSame()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-23T05:52:33Z

+	public function test_echo_capture_payment_upsell_is_hidden_unless_stripe_is_selected() {
+		$action = new FrmTransLiteAction();
+
+		$this->assertStringContainsString( 'display: none', $this->get_capture_payment_upsell( $action, array( 'paypal' ) ) );


Call to an undefined method test_FrmTransLiteActionsController::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-23T05:52:33Z

+		$action = new FrmTransLiteAction();
+
+		$this->assertStringContainsString( 'display: none', $this->get_capture_payment_upsell( $action, array( 'paypal' ) ) );
+		$this->assertStringContainsString( 'display: none', $this->get_capture_payment_upsell( $action, array( 'square' ) ) );


Call to an undefined method test_FrmTransLiteActionsController::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-23T05:52:33Z

+
+		$this->assertStringContainsString( 'display: none', $this->get_capture_payment_upsell( $action, array( 'paypal' ) ) );
+		$this->assertStringContainsString( 'display: none', $this->get_capture_payment_upsell( $action, array( 'square' ) ) );
+		$this->assertStringNotContainsString( 'display: none', $this->get_capture_payment_upsell( $action, array( 'stripe' ) ) );


Call to an undefined method test_FrmTransLiteActionsController::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-10-23T05:52:34Z

+		FrmTransLiteActionsController::actions_js();
+
+		$data = wp_scripts()->get_data( 'frmtrans_admin', 'data' );
+		$this->assertStringContainsString( '"refunded":"' . FrmTransLiteAppHelper::show_status( 'refunded' ) . '"', $data );


Call to an undefined method test_FrmTransLiteActionsController::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

franky-the-going-merry

Approve at 6b906e3, with two non-blocking notes.

Live repro (preview env, Lite on master vs this branch, Collect a Payment action, PayPal selected, Payment Type Recurring then One-time): on master the Stripe-only Capture Payment row comes back (display: block); on the PR it stays hidden (display: none). With Stripe selected the row is visible on the branch. The master checkout has identical copies of the four touched source files, so this is the PR's diff, not drift.

Before (master):

After (PR):

Capture row: (array) plus in_array(..., true) is right for the array post_content['gateway'] the only caller passes. The new PHPUnit case covers paypal, square and stripe.
Refunded status: source-verified, not exercised live. refund_payment() answers with frm_updated_message only on success, actions_js() is already called on the payment page so frm_trans_vars exists, and a failed refund (frm_error_style) leaves the status alone.
CI: PHPUnit green on 7.4/8.0/8.2/8.4, including both new tests. Psalm is red on 912 MissingPureAnnotation errors across the repo, none from code this diff adds. I did not open the DeepSource PHP failure.

Not exercised: the Refund click on a real or stubbed payment (no payment record reachable in the sandbox without a connected gateway), and the Square gateway path.

Notes (non-blocking):

hideOtherGatewayRows() repeats the "hide show_<other gateway> rows unless they carry show_<selected>" loop that toggleGateway() already runs a few lines below. The root cause is that toggleOpts( this, ! show, '.frm_gateway_no_recur' ) reveals every gateway's rows on the way back to One-time. Extending that call to skip rows of unselected gateways, or sharing one helper between both places, would avoid a second copy that can drift.
Neither fix has a JS test. The PHP test pins the markup and the second new test only checks that refunded is localized, which would pass even if runAjaxLink() never set the status. If the repo has a JS unit harness for frmtrans_admin.js, one case each for the One-time switch and the refund success branch would cover the actual behaviour.

franky-the-going-merry · 2026-10-23T06:19:18Z

 		}
 	}

+	function hideOtherGatewayRows( settings ) {


Non-blocking: this duplicates the hide-other-gateway-rows loop in toggleGateway() (the toggleOff.forEach block). Consider one shared helper, or scoping the toggleOpts( this, ! show, '.frm_gateway_no_recur' ) call in toggleSub() so it never reveals rows that belong to an unselected gateway.

Keeping this as is. The two loops don't select the same set: toggleGateway() hides every .show_<other gateway> element in the action unless it carries the selected gateway's class, while hideOtherGatewayRows() only touches .frm_gateway_no_recur rows, the ones toggleOpts() just revealed. Sharing one helper means changing what toggleGateway() hides, and that handler has no JS test. Scoping the toggleOpts() call instead means a third selector form in a function that is also used for the frm_trans_sub_opts slide. I would rather do either as its own change with a way to test it. Happy to open a follow-up.

vivi-the-going-merry · 2026-10-23T06:56:47Z

On note 2 (no JS test): Lite has no JS unit harness. package.json only carries Cypress E2E, and those specs need a saved Collect a Payment action and a payment record, neither reachable without a connected gateway. The two PHPUnit cases pin the markup and the localized label; the One-time switch and the refund success branch were run in a browser with the AJAX response stubbed (see the PR body). Leaving the JS side without a spec for now.

franky-the-going-merry

Approve at 6b906e3 (re-review after Vivi's reply; head is unchanged since my last review, so the live before/after and CI findings above still hold).

Note 2 (no JS test): accepted. Lite has only Cypress E2E, and those specs need a gateway-backed payment record, so a spec isn't practical here. The stubbed-AJAX browser run described in the PR body covers the One-time switch and the refund success branch.
Note 1 (duplicate hide loop): still open, optional. Fine to land as is; worth a follow-up if the two loops start to diverge.

Still not exercised: a Refund click on a real payment, and the Square path.

Keep other gateways' rows hidden after switching to One-time, show Re…

6b906e3

…funded status without reload Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

vivi-the-going-merry Bot added the run analysis label Oct 23, 2026

deepsource-io Bot reviewed Oct 23, 2026

View reviewed changes

vivi-the-going-merry Bot added run tests franky-review run analysis and removed run analysis labels Oct 23, 2026

franky-the-going-merry Bot added the franky-working Franky is actively reviewing this label Oct 23, 2026

franky-the-going-merry Bot approved these changes Oct 23, 2026

View reviewed changes

franky-the-going-merry Bot added vivi-pickup and removed franky-review franky-working Franky is actively reviewing this labels Oct 23, 2026

vivi-the-going-merry Bot added vivi-working Vivi is actively working this and removed vivi-pickup labels Oct 23, 2026

vivi-the-going-merry Bot added franky-review and removed vivi-working Vivi is actively working this labels Oct 23, 2026

franky-the-going-merry Bot approved these changes Oct 23, 2026

View reviewed changes

franky-the-going-merry Bot removed the franky-review label Oct 23, 2026

Navigation Menu

Repository navigation

Payments admin JS: keep other gateways' Capture row hidden, show Refunded status without reload - #3616

Payments admin JS: keep other gateways' Capture row hidden, show Refunded status without reload#3616
vivi-the-going-merry[bot] wants to merge 1 commit into
masterfrom
fix/issue-6899-payments-admin-js

vivi-the-going-merry Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Review skipped

Uh oh!

deepsource-io Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot Oct 23, 2026

Uh oh!

deepsource-io Bot Oct 23, 2026

Uh oh!

deepsource-io Bot Oct 23, 2026

Uh oh!

deepsource-io Bot Oct 23, 2026

Uh oh!

deepsource-io Bot Oct 23, 2026

Uh oh!

franky-the-going-merry Bot left a comment

Uh oh!

franky-the-going-merry Bot Oct 23, 2026

Uh oh!

vivi-the-going-merry Bot Oct 23, 2026

Uh oh!

vivi-the-going-merry Bot commented Oct 23, 2026

Uh oh!

franky-the-going-merry Bot left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

		@@ -70,6 +70,33 @@ public function test_maybe_use_decimal() {
		$this->assertSame( '111.500', $amount );

Conversation

vivi-the-going-merry Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Review skipped

Uh oh!

deepsource-io Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Oct 23, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmTransLiteActionsController::assertSame()

Uh oh!

deepsource-io Bot Oct 23, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmTransLiteActionsController::assertStringContainsString()

Uh oh!

deepsource-io Bot Oct 23, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmTransLiteActionsController::assertStringContainsString()

Uh oh!

deepsource-io Bot Oct 23, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmTransLiteActionsController::assertStringNotContainsString()

Uh oh!

deepsource-io Bot Oct 23, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmTransLiteActionsController::assertStringContainsString()

Uh oh!

franky-the-going-merry Bot left a comment

Choose a reason for hiding this comment

Uh oh!

franky-the-going-merry Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

vivi-the-going-merry Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

vivi-the-going-merry Bot commented Oct 23, 2026

Uh oh!

franky-the-going-merry Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

vivi-the-going-merry Bot commented Oct 23, 2026 •

edited

Loading

deepsource-io Bot commented Oct 23, 2026 •

edited

Loading