[vivi-the-going-merry]

Closes Strategy11/formidable-pro#6929

Broken: Style > Field Colors > Error > Field Text didn't reach placeholder text in fields with an error, so placeholders stayed the disabled grey (unreadable on a dark Error background).

Changed: css/_single_theme.css.php adds an error-state placeholder rule (::placeholder, .frm_default, .placeholder) under .frm_blank_field and :invalid, using --text-color-error. A second rule restores the disabled colour for sub fields of a combo field that aren't themselves in error, matching the existing combo-field reset above it.

Verified: Live in a Playground instance on this branch's CSS. Error Background rgba(29,29,27,0.5), Error Field Text #fff, empty required text field with a placeholder, submitted empty. Computed ::placeholder colour: rgb(136,136,136) before, rgb(255,255,255) after.

Before	After

Not verified: combo-field sub-field reset rendered live (selector mirrors the existing reset); CI result.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Strategy11/formidable-forms
• Branch: master
• File: .coderabbit.yaml
• Commit: d31ea91
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 687faf3a-a485-47ab-b074-8cc603a51124

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[deepsource-io]

DeepSource Code Review

We reviewed changes in d31ea91...f71fb06 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Oct 30, 2026 12:24a.m.	Review ↗
JavaScript		Oct 30, 2026 12:24a.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[deepsource-io]

Variable $style_class might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

[franky-the-going-merry]

Approving. Reproduced the bug live on base and confirmed the fix on this branch, using a Playground env with Lite at each commit and the stylesheet regenerated each time (the generated formidableforms.css is cached, so switching branches alone shows stale CSS).

Setup: default style with Error Field Text #fff and Error Background #1d1d1b, one required text field with placeholder "Your name here", submitted empty.

	Computed ::placeholder colour	Screenshot
Base (3a919a7)	rgb(102, 112, 133) (disabled grey, hard to read on the dark error background)
This PR (673bdf5)	rgb(255, 255, 255)

Checked by reading the CSS:

• No regression before submit: on page load the required empty field is not :invalid and its placeholder stays disabled grey. The new :invalid selectors match the existing .frm_form_field :invalid error rule just above them, so the placeholder now follows the same state as the field's own error text, background and border.
• Specificity: the new rule beats both existing placeholder rules (input::placeholder, input.frm_default) by at least one class, and the combo reset beats the new rule when a sub field is not itself in error.
• Floating labels: custom_theme.css.php hides inside-label placeholders with opacity, not color, so this colour change doesn't surface them.
• Same pattern elsewhere: no other error-state placeholder rules exist in css/ that this misses.

Not exercised live: the combo-field sub-field reset (Pro Name/Address). It mirrors the reset directly above it and I only verified its specificity from source. CI: Psalm and DeepSource PHP are red, but this diff is CSS-only inside a PHP template with no PHP logic changed. Reviewed by hand rather than with the review skills, given an 18-line CSS-only diff.

[Crabcyborg]

Added a PHPUnit test, test_FrmStyle::test_generated_css_uses_error_color_for_placeholders_in_fields_with_errors (commit 625d1a6). It renders custom_theme.css.php through FrmStyle::get_css_content() and asserts that the .frm_blank_field and :invalid placeholder selectors use --text-color-error, and that the combo sub-field reset keeps --text-color-disabled. It fails against master CSS and passes on this branch.

Also merged master. test_FrmStyle passes (29 tests) and phpcs (Lite ruleset) is clean.

[deepsource-io]

Call to an undefined method test_FrmStyle::assertMatchesRegularExpression()

The method you are trying to call is not defined, which can result in a fatal error.

[deepsource-io]

Call to an undefined method test_FrmStyle::assertMatchesRegularExpression()

The method you are trying to call is not defined, which can result in a fatal error.

[deepsource-io]

Call to an undefined method test_FrmStyle::assertMatchesRegularExpression()

The method you are trying to call is not defined, which can result in a fatal error.