fix: act on the active player when none is configured - #37
Open
mhlas7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_matching_ifaces returned every MPRIS player when no player was picked in the settings, so play, pause and toggle were broadcast to all of them. With a video paused and music paused, one press of a play/pause key resumed both at once, where a keyboard media key resumes only what played last.
Narrow the unconfigured case to the active player: whatever is playing, or whatever played last when nothing is. Several players that are all playing are still paused together, since a pause key should silence everything.
The docstrings already described this behaviour, as does actions.json. This change simply fixes the play/pause behavior to do what is claimed in the documentation.