Repository navigation
PersianErrors: support Subtitle Edit Batch convert - #331
Merged
Merged
Conversation
- plugin.json "batch": true - batch request: run the saved enabled groups over every line and keep every fix (OK with the default selection, one pass), no UI - configure request: settings-only window (group sidebar), settings returned without subtitle; remembered scope/display options are kept Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Batch convert support (SubtitleEdit/subtitleedit#16036 contract) to Persian Subtitle Fixes.
Batch (
requestType: "batch")disabledGroups) over all lines and keeps every fix.okwith the subtitle when lines changed,okwithout a subtitle when nothing needs fixing. Settings are null in the response.Configure (
requestType: "configure")okwith settings + settingsVersion and no subtitle; Cancel returnscancelled.Decisions
selectedLinesOnlydoes not apply (batch has no selection), so all lines are fixed.selectedLinesOnly(andshowHidden) unchanged instead of resetting them to false.PersianFixer.FindFixessynchronously.Compatibility
Subtitle Edit 5.3 ignores
"batch"and only sends"run"; the run path is unchanged.Tests
BatchModeTests(5): fixes all lines, nothing-to-fix is ok without subtitle, disabled groups skipped, scope ignored, configure returns settings only and keeps remembered options.dotnet test se5/PersianErrors.Tests: 37 passed.batchrequest.json run against the built dll exits 0 and returns the fixed lines.🤖 Generated with Claude Code