Repository navigation
Fix catalogue re-import deleting tastings and reverting edits - #24
Merged
Merged
Conversation
Use OnConflictStrategy.IGNORE for bulk catalogue inserts so existing wine rows are not deleted and re-created (which CASCADE-deleted tastings). Apply delta catalogue updates with Room @update instead of REPLACE insert. Add instrumented DAO test for re-import preserving tastings and user edits. Co-authored-by: T0liver <T0liver@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
Cause
WineDao.insertAllusedOnConflictStrategy.REPLACE, which deletes and re-inserts an existing wine row on catalogue re-import.TasteEntityreferences wines withonDelete = CASCADE, so every re-import wiped tastings for catalogue wines and replaced user-edited fields with catalogue data.Fix
OnConflictStrategy.IGNOREso existing rows (and their tastings) are left intact and user edits are not overwritten on full re-import or file import.WineDao.updateAll/WineRepository.updateAllso corrected catalogue fields apply with an in-placeUPDATEinstead of delete-and-reinsert.CatalogImportPreservesDataTest(instrumented Room test) covering re-import after a user edit and a recorded tasting.Verification
./gradlew assembleDebug compileDebugAndroidTestKotlin— BUILD SUCCESSFUL