Repository navigation
Fix dashboard infinite spinner after Delete all data - #26
Merged
Merged
Conversation
Keep a single live combine subscription instead of canceling and re-subscribing on refresh, which could leave isLoading true until the next DB change. Co-authored-by: T0liver <T0liver@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Cause
DashboardViewModel.loadDashboard()cancelled the active flow subscription on every load/refresh and started a newcombine()over Room/DataStore sources. After clearing data, the new subscription could fail to complete the combined emission promptly, leavingisLoading = truewhilerecentTastingswas already empty — hence the endless spinner until a later DB change (e.g. adding a wine).Fix
combinecollection (observeDashboard).DashboardViewModelTestcovering empty-state loading clearance and ensuring refresh does not re-subscribe.Test plan
./gradlew assembleDebug testDebugUnitTest(with-Dorg.gradle.jvmargs="-Xmx4g")