Skip to content

Fix colour filter chips cut off on narrow screens (fixes #18) - #28

Merged
T0liver merged 1 commit into
mainfrom
c-fix-colour-filter-chips-0966
Nov 21, 2026
Merged

T0liver merged 1 commit into
mainfrom
c-fix-colour-filter-chips-0966

Conversation

@T0liver

@T0liver T0liver commented Nov 21, 2026

Copy link
Copy Markdown
Owner

Fixes #18

Cause

The filter sheet rendered wine colour options in a single Row(Modifier.fillMaxWidth()). With eight FilterChips, anything that did not fit on one line was clipped with no horizontal scroll, so Red, Tawny, and Schiller were unreachable on typical phone widths.

Fix

Use FlowRow with horizontal and vertical spacing so chips wrap onto additional lines at narrow widths and with larger font scale. Matches the existing FlowRow pattern in SegmentedSelector.kt.

Scope

  • Changed: WineFilterSheet.kt only (colour chip row).
  • Unchanged: WineFormSheet already uses WineColourDropdown, not chips.

Overlap with #27

PR #27 (c-fix-bottom-sheet-dismiss-3809) also edits WineFilterSheet.kt for dismiss/discard behavior. This change is limited to the colour FlowRow block (lines ~106–124) and should merge cleanly alongside #27’s sheet-state logic.

Open in Web Open in Cursor 

Replace a single-line Row with FlowRow so all WineColour chips wrap
instead of being clipped off the right edge of the filter sheet.

Co-authored-by: T0liver <T0liver@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fbe6ecd. ± Comparison against base commit c865cc7.

@T0liver
T0liver merged commit 66201ef into main Nov 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Automated test] Colour filter chips are cut off, so Red can't be selected

2 participants